Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: WAFv2 update rules shared with Firewall Manager #36941

Open
stumyp opened this issue Apr 16, 2024 · 1 comment
Open

[New Resource]: WAFv2 update rules shared with Firewall Manager #36941

stumyp opened this issue Apr 16, 2024 · 1 comment
Labels
new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/wafv2 Issues and PRs that pertain to the wafv2 service.

Comments

@stumyp
Copy link

stumyp commented Apr 16, 2024

Description

Current Limitations

The Terraform AWS provider does use the UpdateWebACL API, but only for updating WAF ACLs that it manages and not quite in the way we need for dynamically managing shared Web ACLs within organizations using AWS Firewall Manager (FMS). This functionality is key as it allows different accounts to add their own rules to a shared Web ACL, promoting a flexible approach to security management.

Why We Need Enhanced UpdateWebACL Support

As outlined in the AWS documentation on WAF policies, web ACLs managed by FMS have three sets of rules:

  1. First rule groups: These are defined by the Firewall Manager policy and are the first to be evaluated.
  2. Account-managed rules: These are added and managed by account managers and come next in the evaluation order.
  3. Last rule groups: Like the first, these are defined by the Firewall Manager policy and evaluated last.

Currently, the aws_fms_policy resource in Terraform handles the first and last rule groups. What we’re missing is the ability for Terraform to handle the middle group — the account-managed rules — using an enhanced version of the UpdateWebACL API.

Proposed Feature

I suggest we beef up the existing implementation of the UpdateWebACL API within the Terraform AWS provider. This enhancement would allow account managers to update rules within shared Web ACLs directly through Terraform, which would be especially useful for environments managed across multiple accounts through FMS.

Use Case

This feature is crucial for organizations that manage centralized security policies but need the flexibility to tailor rules to specific account needs. Allowing account managers to update rules directly through Terraform will help ensure that security setups are both adaptable and consistently applied.

Requested Resource(s) and/or Data Source(s)

aws_wafv2_updatesharedacl

Potential Terraform Configuration

Similar to what is currently supported by `aws_wafv2_rule_group`

References

No response

Would you like to implement a fix?

No

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/wafv2 Issues and PRs that pertain to the wafv2 service. label Apr 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 16, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
@nam054 nam054 self-assigned this Nov 12, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 12, 2024
@nam054 nam054 removed their assignment Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
Development

No branches or pull requests

3 participants