-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #20216 #20265
Fix for issue #20216 #20265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTableAssociation_ -timeout 180m
=== RUN TestAccAWSRouteTableAssociation_Subnet_basic
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_basic
=== RUN TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== RUN TestAccAWSRouteTableAssociation_Gateway_basic
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_basic
=== RUN TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== RUN TestAccAWSRouteTableAssociation_disappears
=== PAUSE TestAccAWSRouteTableAssociation_disappears
=== CONT TestAccAWSRouteTableAssociation_Subnet_basic
=== CONT TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== CONT TestAccAWSRouteTableAssociation_disappears
=== CONT TestAccAWSRouteTableAssociation_Gateway_basic
=== CONT TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
--- PASS: TestAccAWSRouteTableAssociation_disappears (43.24s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (46.00s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (66.01s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (75.27s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (97.04s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 100.327s
@obourdon Thanks for the contribution 🎉 👏. |
@ewbankkit many thanks for such a prompt integration. Cheers |
This functionality has been released in v3.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20216
Output from acceptance testing: