Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/lakeformation_permissions: Add unit tests for permission filtering #19860

Closed
YakDriver opened this issue Jun 17, 2021 · 2 comments · Fixed by #19817
Closed

r/lakeformation_permissions: Add unit tests for permission filtering #19860

YakDriver opened this issue Jun 17, 2021 · 2 comments · Fixed by #19817
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Jun 17, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Relates #19817

The file aws/internal/lakeformation/filter.go needs associated unit tests. These will be medium complexity because we'll need varying lists of "allPermissions", various inputs (ListPermissionsInput) plus columns, exclude columns, and wildcards, and then to verify that we get the right results.

New or Affected Resource(s)

  • aws_lakeformation_permissions

References

@YakDriver YakDriver added enhancement Requests to existing resources that expand the functionality or scope. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jun 17, 2021
@github-actions github-actions bot added the service/lakeformation Issues and PRs that pertain to the lakeformation service. label Jun 17, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 17, 2021
@YakDriver YakDriver self-assigned this Jun 17, 2021
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant