added eks cluster_name validation

[philnichol]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18806

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -run=TestResourceAWSEKSClusterNameValidation
=== RUN   TestResourceAWSEKSClusterNameValidation
--- PASS: TestResourceAWSEKSClusterNameValidation (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.690s

Thanks in advance for your review!

The regex listed in the documentation is actually incorrect, I've left feedback on that page so hopefully it gets corrected
https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateCluster.html
Listed as ^[0-9A-Za-z][A-Za-z0-9\-_]* but should be ^[0-9A-Za-z][A-Za-z0-9\-_]+$.

Wasn't sure if I had to run acc tests for the resources themselves so please let me know if I do, I just skipped them since it will be expensive and long, but can run them if required 😄

[bflad]

Hi @philnichol 👋 Thank you for submitting this. Just a drive-by comment about the unit test failure that if you rebase against the main branch, it should be resolved. 👍

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[philnichol]

Thanks @bflad , and apologies for incorrect branch name and missing CHANGELOG stuff, haven't contributed in a while and submitted before reading updated contributing guidelines, should probably be named td-.

[gdavison]

Looks good 🚀

I've updated the changelog file to have one release-note block per change.

Acceptance test results

--- PASS: TestAccAWSEksFargateProfile_disappears (1316.49s)
--- PASS: TestAccAWSEksFargateProfile_Multi_Profile (1682.64s)

[philnichol]

Looks good 🚀

I've updated the changelog file to have one release-note block per change.

Acceptance test results

--- PASS: TestAccAWSEksFargateProfile_disappears (1316.49s)

--- PASS: TestAccAWSEksFargateProfile_Multi_Profile (1682.64s)

Thanks for that!

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.