Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/iam: Handle read-after-create eventual consistency in IAM Role resources #18435

Merged
merged 2 commits into from
Apr 1, 2021
Merged

service/iam: Handle read-after-create eventual consistency in IAM Role resources #18435

merged 2 commits into from
Apr 1, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 26, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12127
Closes #16247
Closes #18457
Reference: #16796

Output from acceptance testing in AWS Commerical:

--- PASS: TestAccAWSIAMRole_badJSON (11.02s)
--- PASS: TestAccAWSIAMRole_basic (23.54s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (53.20s)
--- PASS: TestAccAWSIAMRole_disappears (46.04s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (51.73s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (87.07s)
--- PASS: TestAccAWSIAMRole_namePrefix (24.63s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (124.99s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (100.26s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (49.13s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (97.33s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (94.08s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (74.63s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (76.32s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (79.85s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (76.09s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (77.20s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (77.85s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (77.66s)
--- PASS: TestAccAWSIAMRole_tags (80.65s)
--- PASS: TestAccAWSIAMRole_testNameChange (82.60s)

--- PASS: TestAccAWSIAMRolePolicy_basic (49.38s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (46.58s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (67.85s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (4.22s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (56.10s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (26.78s)

--- PASS: TestAccAWSRolePolicyAttachment_basic (81.14s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (28.61s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (32.83s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSIAMRole_badJSON (15.80s)
--- PASS: TestAccAWSIAMRole_basic (56.37s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (117.55s)
--- PASS: TestAccAWSIAMRole_disappears (32.81s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (65.18s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (88.44s)
--- PASS: TestAccAWSIAMRole_namePrefix (56.26s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (135.60s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (98.21s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (39.47s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (98.71s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (112.38s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (82.67s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (76.48s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (85.73s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (84.34s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (86.56s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (66.74s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (74.49s)
--- PASS: TestAccAWSIAMRole_tags (74.03s)
--- PASS: TestAccAWSIAMRole_testNameChange (93.57s)

--- PASS: TestAccAWSIAMRolePolicy_basic (78.62s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (35.25s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (100.35s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (9.46s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (84.49s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (27.87s)

--- PASS: TestAccAWSRolePolicyAttachment_basic (88.63s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (32.95s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (43.69s)

@bflad
service/iam: Handle read-after-create eventual consistency in IAM Rol…
3f95854 
…e resources

Reference: #12127
Reference: #16247
Reference: #16796

Output from acceptance testing in AWS Commerical:

```
--- PASS: TestAccAWSIAMRole_badJSON (11.02s)
--- PASS: TestAccAWSIAMRole_basic (23.54s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (53.20s)
--- PASS: TestAccAWSIAMRole_disappears (46.04s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (51.73s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (87.07s)
--- PASS: TestAccAWSIAMRole_namePrefix (24.63s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (124.99s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (100.26s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (49.13s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (97.33s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (94.08s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (74.63s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (76.32s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (79.85s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (76.09s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (77.20s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (77.85s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (77.66s)
--- PASS: TestAccAWSIAMRole_tags (80.65s)
--- PASS: TestAccAWSIAMRole_testNameChange (82.60s)

--- PASS: TestAccAWSIAMRolePolicy_basic (49.38s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (46.58s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (67.85s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (4.22s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (56.10s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (26.78s)

--- PASS: TestAccAWSRolePolicyAttachment_basic (81.14s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (28.61s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (32.83s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSIAMRole_badJSON (15.80s)
--- PASS: TestAccAWSIAMRole_basic (56.37s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (117.55s)
--- PASS: TestAccAWSIAMRole_disappears (32.81s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (65.18s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (88.44s)
--- PASS: TestAccAWSIAMRole_namePrefix (56.26s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (135.60s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (98.21s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (39.47s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (98.71s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (112.38s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (82.67s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (76.48s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (85.73s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (84.34s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (86.56s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (66.74s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (74.49s)
--- PASS: TestAccAWSIAMRole_tags (74.03s)
--- PASS: TestAccAWSIAMRole_testNameChange (93.57s)

--- PASS: TestAccAWSIAMRolePolicy_basic (78.62s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (35.25s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (100.35s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (9.46s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (84.49s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (27.87s)

--- PASS: TestAccAWSRolePolicyAttachment_basic (88.63s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (32.95s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (43.69s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Mar 26, 2021
@bflad bflad requested a review from a team as a code owner March 26, 2021 20:54
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. labels Mar 26, 2021
@bflad bflad mentioned this pull request Mar 29, 2021
Closed
@bflad bflad linked an issue Mar 29, 2021 that may be closed by this pull request
Error: Provider produced inconsistent result after apply AWS_IAM_ROLE_ATTACHMENT_TASK #18457
Closed
@YakDriver YakDriver self-assigned this Apr 1, 2021
YakDriver
YakDriver approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Acceptance tests on GovCloud:

--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (24.40s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (25.99s)
--- PASS: TestAccAWSRolePolicyAttachment_basic (49.08s)

--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (3.93s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (15.34s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (25.54s)
--- PASS: TestAccAWSIAMRolePolicy_basic (51.12s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (57.89s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (58.22s)

--- PASS: TestAccAWSIAMRole_badJSON (6.42s)
--- PASS: TestAccAWSIAMRole_disappears (27.00s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (28.39s)
--- PASS: TestAccAWSIAMRole_basic (31.68s)
--- PASS: TestAccAWSIAMRole_namePrefix (36.52s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (36.72s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (50.61s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (50.79s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (50.97s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (54.06s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (54.64s)
--- PASS: TestAccAWSIAMRole_tags (56.70s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (59.07s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (59.11s)
--- PASS: TestAccAWSIAMRole_testNameChange (62.42s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (64.39s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (70.18s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (75.73s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (79.11s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (84.48s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (108.29s)

Acceptance tests on commercial:

--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (3.11s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (12.88s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (20.00s)
--- PASS: TestAccAWSIAMRolePolicy_basic (36.65s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (37.51s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (40.07s)

--- PASS: TestAccAWSIAMRole_disappears (26.14s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (27.62s)
--- PASS: TestAccAWSIAMRole_badJSON (4.00s)
--- PASS: TestAccAWSIAMRole_basic (30.60s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (31.78s)
--- PASS: TestAccAWSIAMRole_namePrefix (32.66s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (39.45s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (41.44s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (42.52s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (43.22s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (43.59s)
--- PASS: TestAccAWSIAMRole_tags (44.40s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (45.02s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (45.14s)
--- PASS: TestAccAWSIAMRole_testNameChange (46.19s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (47.78s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (51.71s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (53.56s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (55.93s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (56.03s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (68.79s)

--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (16.52s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (16.52s)
--- PASS: TestAccAWSRolePolicyAttachment_basic (33.03s)

@bflad bflad merged commit 4e03018 into main Apr 1, 2021
@bflad bflad deleted the b-aws_iam_role-IsNewResource branch April 1, 2021 19:09
@github-actions github-actions bot added this to the v3.35.0 milestone Apr 1, 2021
github-actions bot pushed a commit that referenced this pull request Apr 1, 2021
Update CHANGELOG.md for #18435
1a598d5
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.35.0
2 participants
@bflad @YakDriver