r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled #17739

ewbankkit · 2021-02-21T23:43:38Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_\|TestAccAwsGlobalAcceleratorListener_\|TestAccAwsGlobalAcceleratorAccelerator_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_\|TestAccAwsGlobalAcceleratorListener_\|TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_disappears
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_update
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== RUN   TestAccAwsGlobalAcceleratorListener_basic
=== PAUSE TestAccAwsGlobalAcceleratorListener_basic
=== RUN   TestAccAwsGlobalAcceleratorListener_disappears
=== PAUSE TestAccAwsGlobalAcceleratorListener_disappears
=== RUN   TestAccAwsGlobalAcceleratorListener_update
=== PAUSE TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (71.14s)
=== CONT  TestAccAwsGlobalAcceleratorListener_update
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (190.26s)
=== CONT  TestAccAwsGlobalAcceleratorListener_disappears
=== CONT  TestAccAwsGlobalAcceleratorListener_basic
--- PASS: TestAccAwsGlobalAcceleratorListener_update (158.63s)
--- PASS: TestAccAwsGlobalAcceleratorListener_disappears (120.03s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_Update
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (184.09s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (257.05s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (187.01s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (174.95s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (213.72s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (664.05s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_disappears
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (708.09s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (173.58s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (91.68s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_update
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (279.32s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_disappears
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (115.97s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (185.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1890.885s

…ibutes. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m === RUN TestAccAwsGlobalAcceleratorAccelerator_basic === PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic === RUN TestAccAwsGlobalAcceleratorAccelerator_update === PAUSE TestAccAwsGlobalAcceleratorAccelerator_update === RUN TestAccAwsGlobalAcceleratorAccelerator_attributes === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes === RUN TestAccAwsGlobalAcceleratorAccelerator_tags === PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags === CONT TestAccAwsGlobalAcceleratorAccelerator_basic === CONT TestAccAwsGlobalAcceleratorAccelerator_tags === CONT TestAccAwsGlobalAcceleratorAccelerator_attributes === CONT TestAccAwsGlobalAcceleratorAccelerator_update --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (74.71s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (98.44s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (111.19s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (111.53s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 111.631s

… add CustomizeDiff.

… '_disappears' test (hashicorp#13826, hashicorp#13527). Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m === RUN TestAccAwsGlobalAcceleratorAccelerator_basic === PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic === RUN TestAccAwsGlobalAcceleratorAccelerator_disappears === PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears === RUN TestAccAwsGlobalAcceleratorAccelerator_update === PAUSE TestAccAwsGlobalAcceleratorAccelerator_update === RUN TestAccAwsGlobalAcceleratorAccelerator_attributes === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes === RUN TestAccAwsGlobalAcceleratorAccelerator_tags === PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags === CONT TestAccAwsGlobalAcceleratorAccelerator_basic === CONT TestAccAwsGlobalAcceleratorAccelerator_attributes === CONT TestAccAwsGlobalAcceleratorAccelerator_tags === CONT TestAccAwsGlobalAcceleratorAccelerator_update === CONT TestAccAwsGlobalAcceleratorAccelerator_disappears --- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (68.53s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (77.55s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (101.99s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (103.04s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (112.32s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 112.414s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m === RUN TestAccAwsGlobalAcceleratorAccelerator_basic === PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic === RUN TestAccAwsGlobalAcceleratorAccelerator_disappears === PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears === RUN TestAccAwsGlobalAcceleratorAccelerator_update === PAUSE TestAccAwsGlobalAcceleratorAccelerator_update === RUN TestAccAwsGlobalAcceleratorAccelerator_attributes === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes === RUN TestAccAwsGlobalAcceleratorAccelerator_tags === PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags === CONT TestAccAwsGlobalAcceleratorAccelerator_basic === CONT TestAccAwsGlobalAcceleratorAccelerator_attributes === CONT TestAccAwsGlobalAcceleratorAccelerator_tags === CONT TestAccAwsGlobalAcceleratorAccelerator_update === CONT TestAccAwsGlobalAcceleratorAccelerator_disappears --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (66.21s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (70.15s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (101.99s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (105.02s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (114.42s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 114.558s

…refix attributes while flows are enabled, first disable flow logs. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_attributes' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_attributes -timeout 120m === RUN TestAccAwsGlobalAcceleratorAccelerator_attributes === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes === CONT TestAccAwsGlobalAcceleratorAccelerator_attributes --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (270.49s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 270.583s Without the fix the test failed: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_attributes' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_attributes -timeout 120m === RUN TestAccAwsGlobalAcceleratorAccelerator_attributes === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes === CONT TestAccAwsGlobalAcceleratorAccelerator_attributes resource_aws_globalaccelerator_accelerator_test.go:285: Step 4/5 error: Error running apply: exit status 1 2021/02/21 16:43:59 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.13.0 Error: error updating Global Accelerator Accelerator (arn:aws:globalaccelerator::346386234494:accelerator/6319d8d8-c21d-4f2d-b685-cd66271d3171) attributes: InvalidArgumentException: Subscription already exists: BucketName[tf-acc-test-6489429174030632786] Prefix[flow-logs/]. Please delete and recreate the subscription if you want to change the config of your subscription. --- FAIL: TestAccAwsGlobalAcceleratorAccelerator_attributes (166.85s) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 166.947s FAIL GNUmakefile:27: recipe for target 'testacc' failed make: *** [testacc] Error 1

…r packages. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_basic -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_basic === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic === CONT TestAccAwsGlobalAcceleratorEndpointGroup_basic --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (177.37s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 177.444s

…ages. Add '_disappears' test (hashicorp#13826, hashicorp#13527). Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorListener_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorListener_disappears -timeout 120m === RUN TestAccAwsGlobalAcceleratorListener_disappears === PAUSE TestAccAwsGlobalAcceleratorListener_disappears === CONT TestAccAwsGlobalAcceleratorListener_disappears --- PASS: TestAccAwsGlobalAcceleratorListener_disappears (120.32s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 120.416s

DrFaust92

Changelog comment otherwise LGTM:

messed up output but all tests passed :D

PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2636.305s

.changelog/17739.txt

…e validations.

DrFaust92

LGTM!

breathingdust · 2021-03-04T18:31:30Z

LGTM 🚀 Thanks @ewbankkit!

Verified Acceptance Tests in Commercial (us-west-2)

ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_\|TestAccAwsGlobalAcceleratorListener_\|TestAccAwsGlobalAcceleratorAccelerator_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_\|TestAccAwsGlobalAcceleratorListener_\|TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_disappears
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_update
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== RUN   TestAccAwsGlobalAcceleratorListener_basic
=== PAUSE TestAccAwsGlobalAcceleratorListener_basic
=== RUN   TestAccAwsGlobalAcceleratorListener_disappears
=== PAUSE TestAccAwsGlobalAcceleratorListener_disappears
=== RUN   TestAccAwsGlobalAcceleratorListener_update
=== PAUSE TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (67.36s)
=== CONT  TestAccAwsGlobalAcceleratorListener_update
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (181.51s)
=== CONT  TestAccAwsGlobalAcceleratorListener_disappears
--- PASS: TestAccAwsGlobalAcceleratorListener_update (160.94s)
=== CONT  TestAccAwsGlobalAcceleratorListener_basic
--- PASS: TestAccAwsGlobalAcceleratorListener_disappears (174.83s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_Update
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (164.28s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (211.11s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (175.23s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (237.50s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (273.92s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (553.56s)
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_disappears
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (699.12s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (182.40s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (87.64s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_update
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (165.20s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_disappears
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (292.03s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (71.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1868.914s

ghost · 2021-03-05T00:16:39Z

This has been released in version 3.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-04-04T17:11:28Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit added 8 commits February 11, 2021 16:47

r/aws_globalaccelerator_accelerator: Enhance attribute validation and…

3b43ba3

… add CustomizeDiff.

r/aws_globalaccelerator_accelerator: Remove CustomizeDiff.

bd18053

ewbankkit requested a review from a team as a code owner February 21, 2021 23:43

ghost added size/XXL Managed by automation to categorize the size of a PR. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 21, 2021

Add CHANGELOG entry.

a982857

ewbankkit changed the title ~~[WIP] r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled~~ r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled Feb 22, 2021

ewbankkit mentioned this pull request Feb 22, 2021

tests/resource/aws_globalaccelerator_accelerator: Simplify sweepers #17740

Closed

Add test for extracting accelerator ARN from endpoint group ARN.

8b2ae0d

ewbankkit assigned DrFaust92 Feb 23, 2021

DrFaust92 suggested changes Feb 25, 2021

View reviewed changes

.changelog/17739.txt Show resolved Hide resolved

r/aws_globalaccelerator_accelerator: Add CHANGELOG entry for plan tim…

87de131

…e validations.

DrFaust92 approved these changes Feb 26, 2021

View reviewed changes

breathingdust merged commit 366aa1d into hashicorp:main Mar 4, 2021

github-actions bot added this to the v3.31.0 milestone Mar 4, 2021

ewbankkit deleted the b-aws_globalaccelerator_accelerator-update-flow-logs branch March 4, 2021 18:32

ewbankkit mentioned this pull request Mar 8, 2021

Validation check of Global Accelerator is different from AWS Console #17978

Closed

e-moshaya mentioned this pull request Mar 15, 2021

Name plan time validation aws_globalaccelerator_accelerator broken #18110

Closed

ghost locked as resolved and limited conversation to collaborators Apr 4, 2021

DrFaust92 removed their assignment Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled #17739

r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled #17739

ewbankkit commented Feb 21, 2021 •

edited

Loading

DrFaust92 left a comment

DrFaust92 left a comment

breathingdust commented Mar 4, 2021

ghost commented Mar 5, 2021

ghost commented Apr 4, 2021

r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled #17739

r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled #17739

Conversation

ewbankkit commented Feb 21, 2021 • edited Loading

Community Note

DrFaust92 left a comment

Choose a reason for hiding this comment

DrFaust92 left a comment

Choose a reason for hiding this comment

breathingdust commented Mar 4, 2021

ghost commented Mar 5, 2021

ghost commented Apr 4, 2021

ewbankkit commented Feb 21, 2021 •

edited

Loading