Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/added new options to cloudfront distribution resource #16049

Merged
merged 3 commits into from
May 28, 2021
Merged

enhancement/added new options to cloudfront distribution resource #16049

merged 3 commits into from
May 28, 2021

Conversation

philnichol
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15752
Closes #16009

Release note for CHANGELOG:

resource/aws_cloudfront_distribution: Add `origin_shield`, `connection_attempts` and `connection_timeout` arguments to `origin` block

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestCloudFrontStructure_ -timeout 60m
=== RUN   TestCloudFrontStructure_expandCloudFrontDefaultCacheBehavior
--- PASS: TestCloudFrontStructure_expandCloudFrontDefaultCacheBehavior (0.00s)
=== RUN   TestCloudFrontStructure_expandTrustedSigners
--- PASS: TestCloudFrontStructure_expandTrustedSigners (0.00s)
=== RUN   TestCloudFrontStructure_flattenTrustedSigners
--- PASS: TestCloudFrontStructure_flattenTrustedSigners (0.00s)
=== RUN   TestCloudFrontStructure_expandTrustedSigners_empty
--- PASS: TestCloudFrontStructure_expandTrustedSigners_empty (0.00s)
=== RUN   TestCloudFrontStructure_expandLambdaFunctionAssociations
--- PASS: TestCloudFrontStructure_expandLambdaFunctionAssociations (0.00s)
=== RUN   TestCloudFrontStructure_flattenlambdaFunctionAssociations
--- PASS: TestCloudFrontStructure_flattenlambdaFunctionAssociations (0.00s)
=== RUN   TestCloudFrontStructure_expandlambdaFunctionAssociations_empty
--- PASS: TestCloudFrontStructure_expandlambdaFunctionAssociations_empty (0.00s)
=== RUN   TestCloudFrontStructure_expandForwardedValues
--- PASS: TestCloudFrontStructure_expandForwardedValues (0.00s)
=== RUN   TestCloudFrontStructure_flattenForwardedValues
--- PASS: TestCloudFrontStructure_flattenForwardedValues (0.00s)
=== RUN   TestCloudFrontStructure_expandHeaders
--- PASS: TestCloudFrontStructure_expandHeaders (0.00s)
=== RUN   TestCloudFrontStructure_flattenHeaders
--- PASS: TestCloudFrontStructure_flattenHeaders (0.00s)
=== RUN   TestCloudFrontStructure_expandQueryStringCacheKeys
--- PASS: TestCloudFrontStructure_expandQueryStringCacheKeys (0.00s)
=== RUN   TestCloudFrontStructure_flattenQueryStringCacheKeys
--- PASS: TestCloudFrontStructure_flattenQueryStringCacheKeys (0.00s)
=== RUN   TestCloudFrontStructure_expandCookiePreference
--- PASS: TestCloudFrontStructure_expandCookiePreference (0.00s)
=== RUN   TestCloudFrontStructure_flattenCookiePreference
--- PASS: TestCloudFrontStructure_flattenCookiePreference (0.00s)
=== RUN   TestCloudFrontStructure_expandCookieNames
--- PASS: TestCloudFrontStructure_expandCookieNames (0.00s)
=== RUN   TestCloudFrontStructure_flattenCookieNames
--- PASS: TestCloudFrontStructure_flattenCookieNames (0.00s)
=== RUN   TestCloudFrontStructure_expandAllowedMethods
--- PASS: TestCloudFrontStructure_expandAllowedMethods (0.00s)
=== RUN   TestCloudFrontStructure_flattenAllowedMethods
--- PASS: TestCloudFrontStructure_flattenAllowedMethods (0.00s)
=== RUN   TestCloudFrontStructure_expandCachedMethods
--- PASS: TestCloudFrontStructure_expandCachedMethods (0.00s)
=== RUN   TestCloudFrontStructure_flattenCachedMethods
--- PASS: TestCloudFrontStructure_flattenCachedMethods (0.00s)
=== RUN   TestCloudFrontStructure_expandOrigins
--- PASS: TestCloudFrontStructure_expandOrigins (0.00s)
=== RUN   TestCloudFrontStructure_flattenOrigins
--- PASS: TestCloudFrontStructure_flattenOrigins (0.00s)
=== RUN   TestCloudFrontStructure_expandOriginGroups
--- PASS: TestCloudFrontStructure_expandOriginGroups (0.00s)
=== RUN   TestCloudFrontStructure_flattenOriginGroups
--- PASS: TestCloudFrontStructure_flattenOriginGroups (0.00s)
=== RUN   TestCloudFrontStructure_expandOrigin
--- PASS: TestCloudFrontStructure_expandOrigin (0.00s)
=== RUN   TestCloudFrontStructure_flattenOrigin
--- PASS: TestCloudFrontStructure_flattenOrigin (0.00s)
=== RUN   TestCloudFrontStructure_expandCustomHeaders
--- PASS: TestCloudFrontStructure_expandCustomHeaders (0.00s)
=== RUN   TestCloudFrontStructure_flattenCustomHeaders
--- PASS: TestCloudFrontStructure_flattenCustomHeaders (0.00s)
=== RUN   TestCloudFrontStructure_flattenOriginCustomHeader
--- PASS: TestCloudFrontStructure_flattenOriginCustomHeader (0.00s)
=== RUN   TestCloudFrontStructure_expandOriginCustomHeader
--- PASS: TestCloudFrontStructure_expandOriginCustomHeader (0.00s)
=== RUN   TestCloudFrontStructure_expandCustomOriginConfig
--- PASS: TestCloudFrontStructure_expandCustomOriginConfig (0.00s)
=== RUN   TestCloudFrontStructure_flattenCustomOriginConfig
--- PASS: TestCloudFrontStructure_flattenCustomOriginConfig (0.00s)
=== RUN   TestCloudFrontStructure_expandCustomOriginConfigSSL
--- PASS: TestCloudFrontStructure_expandCustomOriginConfigSSL (0.00s)
=== RUN   TestCloudFrontStructure_flattenCustomOriginConfigSSL
--- PASS: TestCloudFrontStructure_flattenCustomOriginConfigSSL (0.00s)
=== RUN   TestCloudFrontStructure_expandOriginShield
--- PASS: TestCloudFrontStructure_expandOriginShield (0.00s)
=== RUN   TestCloudFrontStructure_flattenOriginShield
--- PASS: TestCloudFrontStructure_flattenOriginShield (0.00s)
=== RUN   TestCloudFrontStructure_expandS3OriginConfig
--- PASS: TestCloudFrontStructure_expandS3OriginConfig (0.00s)
=== RUN   TestCloudFrontStructure_flattenS3OriginConfig
--- PASS: TestCloudFrontStructure_flattenS3OriginConfig (0.00s)
=== RUN   TestCloudFrontStructure_expandCustomErrorResponses
--- PASS: TestCloudFrontStructure_expandCustomErrorResponses (0.00s)
=== RUN   TestCloudFrontStructure_flattenCustomErrorResponses
--- PASS: TestCloudFrontStructure_flattenCustomErrorResponses (0.00s)
=== RUN   TestCloudFrontStructure_expandCustomErrorResponse
--- PASS: TestCloudFrontStructure_expandCustomErrorResponse (0.00s)
=== RUN   TestCloudFrontStructure_expandCustomErrorResponse_emptyResponseCode
--- PASS: TestCloudFrontStructure_expandCustomErrorResponse_emptyResponseCode (0.00s)
=== RUN   TestCloudFrontStructure_flattenCustomErrorResponse
--- PASS: TestCloudFrontStructure_flattenCustomErrorResponse (0.00s)
=== RUN   TestCloudFrontStructure_expandLoggingConfig
--- PASS: TestCloudFrontStructure_expandLoggingConfig (0.00s)
=== RUN   TestCloudFrontStructure_expandLoggingConfig_nilValue
--- PASS: TestCloudFrontStructure_expandLoggingConfig_nilValue (0.00s)
=== RUN   TestCloudFrontStructure_expandAliases
--- PASS: TestCloudFrontStructure_expandAliases (0.00s)
=== RUN   TestCloudFrontStructure_flattenAliases
--- PASS: TestCloudFrontStructure_flattenAliases (0.00s)
=== RUN   TestCloudFrontStructure_expandRestrictions
--- PASS: TestCloudFrontStructure_expandRestrictions (0.00s)
=== RUN   TestCloudFrontStructure_expandGeoRestriction_whitelist
--- PASS: TestCloudFrontStructure_expandGeoRestriction_whitelist (0.00s)
=== RUN   TestCloudFrontStructure_flattenGeoRestriction_whitelist
--- PASS: TestCloudFrontStructure_flattenGeoRestriction_whitelist (0.00s)
=== RUN   TestCloudFrontStructure_expandGeoRestriction_no_items
--- PASS: TestCloudFrontStructure_expandGeoRestriction_no_items (0.00s)
=== RUN   TestCloudFrontStructure_flattenGeoRestriction_no_items
--- PASS: TestCloudFrontStructure_flattenGeoRestriction_no_items (0.00s)
=== RUN   TestCloudFrontStructure_expandViewerCertificate_cloudfront_default_certificate
--- PASS: TestCloudFrontStructure_expandViewerCertificate_cloudfront_default_certificate (0.00s)
=== RUN   TestCloudFrontStructure_expandViewerCertificate_iam_certificate_id
--- PASS: TestCloudFrontStructure_expandViewerCertificate_iam_certificate_id (0.00s)
=== RUN   TestCloudFrontStructure_expandViewerCertificate_acm_certificate_arn
--- PASS: TestCloudFrontStructure_expandViewerCertificate_acm_certificate_arn (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.041s

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontDistribution_ -timeout 60m
=== RUN   TestAccAWSCloudFrontDistribution_disappears
=== PAUSE TestAccAWSCloudFrontDistribution_disappears
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
=== PAUSE TestAccAWSCloudFrontDistribution_S3Origin
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== PAUSE TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
=== PAUSE TestAccAWSCloudFrontDistribution_customOrigin
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
=== PAUSE TestAccAWSCloudFrontDistribution_multiOrigin
=== RUN   TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== PAUSE TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== RUN   TestAccAWSCloudFrontDistribution_Origin_ConnectionAttempts
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_ConnectionAttempts
=== RUN   TestAccAWSCloudFrontDistribution_Origin_ConnectionTimeout
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_ConnectionTimeout
=== RUN   TestAccAWSCloudFrontDistribution_Origin_OriginShield
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_OriginShield
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== PAUSE TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== RUN   TestAccAWSCloudFrontDistribution_HTTP11Config
=== PAUSE TestAccAWSCloudFrontDistribution_HTTP11Config
=== RUN   TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== PAUSE TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== PAUSE TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== RUN   TestAccAWSCloudFrontDistribution_Enabled
=== PAUSE TestAccAWSCloudFrontDistribution_Enabled
=== RUN   TestAccAWSCloudFrontDistribution_RetainOnDelete
=== PAUSE TestAccAWSCloudFrontDistribution_RetainOnDelete
=== RUN   TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== PAUSE TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== RUN   TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers
=== PAUSE TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers
=== RUN   TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn
=== PAUSE TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn
=== RUN   TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate
=== PAUSE TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate
=== RUN   TestAccAWSCloudFrontDistribution_WaitForDeployment
=== PAUSE TestAccAWSCloudFrontDistribution_WaitForDeployment
=== RUN   TestAccAWSCloudFrontDistribution_OriginGroups
=== PAUSE TestAccAWSCloudFrontDistribution_OriginGroups
=== CONT  TestAccAWSCloudFrontDistribution_disappears
=== CONT  TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== CONT  TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== CONT  TestAccAWSCloudFrontDistribution_OriginGroups
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== CONT  TestAccAWSCloudFrontDistribution_Origin_OriginShield
=== CONT  TestAccAWSCloudFrontDistribution_multiOrigin
=== CONT  TestAccAWSCloudFrontDistribution_WaitForDeployment
=== CONT  TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== CONT  TestAccAWSCloudFrontDistribution_S3Origin
=== CONT  TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate
=== CONT  TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn
=== CONT  TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers
=== CONT  TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== CONT  TestAccAWSCloudFrontDistribution_RetainOnDelete
=== CONT  TestAccAWSCloudFrontDistribution_Enabled
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers
=== CONT  TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== CONT  TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 1 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:21 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (4.45s)
=== CONT  TestAccAWSCloudFrontDistribution_Origin_ConnectionTimeout
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (4.50s)
=== CONT  TestAccAWSCloudFrontDistribution_Origin_ConnectionAttempts
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:24 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:26 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:26 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:26 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:26 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/05 14:50:29 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/11/05 14:50:29 [DEBUG] Waiting for state to become: [success]
=== CONT  TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn
    resource_aws_cloudfront_distribution_test.go:861: Step 1/2 error: Error running apply:
        Error: error importing ACM Certificate: LimitExceededException: You have imported the maximum number of 20 certificates in the last year.


--- FAIL: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (14.39s)
=== CONT  TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
2020/11/05 14:50:33 [DEBUG] Waiting for state to become: [success]
=== CONT  TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate
    resource_aws_cloudfront_distribution_test.go:893: Step 1/2 error: Error running apply:
        Error: error importing ACM Certificate: LimitExceededException: You have imported the maximum number of 20 certificates in the last year.


--- FAIL: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (17.06s)
=== CONT  TestAccAWSCloudFrontDistribution_HTTP11Config
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (238.63s)
=== CONT  TestAccAWSCloudFrontDistribution_customOrigin
--- PASS: TestAccAWSCloudFrontDistribution_disappears (250.53s)
=== CONT  TestAccAWSCloudFrontDistribution_S3OriginWithTags
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (262.29s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (264.33s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (265.31s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (342.97s)
--- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (416.63s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (452.29s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (443.18s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_OriginShield (459.03s)
--- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (459.41s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (512.63s)
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (513.38s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (513.72s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_ConnectionAttempts (509.81s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (515.00s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (498.88s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_ConnectionTimeout (513.22s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (518.18s)
--- PASS: TestAccAWSCloudFrontDistribution_Enabled (628.59s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (390.50s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (552.57s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       804.137s
FAIL

The single failed acceptance test is due to me hitting the quota for imported certificates while testing this locally. The WARN and DEBUG messages appear to be a known issue in terraform.

I lumped origin_shield with the 2 new connection arguments since they were small changes, but happy to move them into their own PR if you want!

@philnichol philnichol requested a review from a team as a code owner November 5, 2020 15:21
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 5, 2020
@cablespaghetti
Copy link

Apologies for the potentially unhelpful comment. However is there any particular reason this hasn't been merged? It seems to have been finished for a month now, and this feature is something we really could use.

Thanks

@philnichol
Copy link
Contributor Author

@cablespaghetti I think these are prioritised based on amount of 👍 on the PR but not 100% sure. Also probably doesn't help that I created a large PR with multiple features bundled in rather then a few smaller separate ones.

Base automatically changed from master to main January 23, 2021 00:59
@bill-rich bill-rich mentioned this pull request May 27, 2021
Closed
@philnichol @bill-rich
added new options to cloudfront distribution resource
3cea22e 
fixed formatting and broken link

Change expected error
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 27, 2021
bill-rich
bill-rich approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Made a few small modifications to align with changes in the provider since the PR was created.

@bill-rich bill-rich merged commit 419df35 into hashicorp:main May 28, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 28, 2021
@philnichol
Copy link
Contributor Author

Thanks @bill-rich, much appreciated!

@philnichol philnichol deleted the e-cloudfront-distribution-adding-features branch May 28, 2021 05:24
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

@chrs-myrs chrs-myrs chrs-myrs approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.43.0
5 participants
@philnichol @cablespaghetti @chrs-myrs @bill-rich @breathingdust