f/aws_sagemaker_model: adding model attribute for container

[nikhil-goenka]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #14891

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerModel_primaryContainerModeSingle'
--- PASS: TestAccAWSSagemakerModel_primaryContainerModeSingle (112.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	114.721s
...

[DrFaust92]

all tests but TestAccAWSSagemakerModel_primaryContainerModeSingle are failing the following way:

=== CONT  TestAccAWSSagemakerModel_primaryContainerEnvironment
    resource_aws_sagemaker_model_test.go:177: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement
        
        Terraform will perform the following actions:
        
          # aws_sagemaker_model.foo must be replaced
        -/+ resource "aws_sagemaker_model" "foo" {
              ~ arn                      = "arn:aws:sagemaker:us-west-2:544685987707:model/terraform-testacc-sagemaker-model-tqxkp6xb1h" -> (known after apply)
              - enable_network_isolation = false -> null
                execution_role_arn       = "arn:aws:iam::544685987707:role/terraform-testacc-sagemaker-model-tqxkp6xb1h"
              ~ id                       = "terraform-testacc-sagemaker-model-tqxkp6xb1h" -> (known after apply)
                name                     = "terraform-testacc-sagemaker-model-tqxkp6xb1h"
        
              ~ primary_container {
                    environment = {
                        "foo" = "bar"
                    }
                    image       = "174872318107.dkr.ecr.us-west-2.amazonaws.com/kmeans:1"
                  - mode        = "SingleModel" -> null
                }
            }

mode needs to be set as default for SingleModel.

[DrFaust92]

nit, wrap with aws.StringValue()

[nikhil-goenka]

all tests but TestAccAWSSagemakerModel_primaryContainerModeSingle are failing the following way:

=== CONT  TestAccAWSSagemakerModel_primaryContainerEnvironment
    resource_aws_sagemaker_model_test.go:177: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement
        
        Terraform will perform the following actions:
        
          # aws_sagemaker_model.foo must be replaced
        -/+ resource "aws_sagemaker_model" "foo" {
              ~ arn                      = "arn:aws:sagemaker:us-west-2:544685987707:model/terraform-testacc-sagemaker-model-tqxkp6xb1h" -> (known after apply)
              - enable_network_isolation = false -> null
                execution_role_arn       = "arn:aws:iam::544685987707:role/terraform-testacc-sagemaker-model-tqxkp6xb1h"
              ~ id                       = "terraform-testacc-sagemaker-model-tqxkp6xb1h" -> (known after apply)
                name                     = "terraform-testacc-sagemaker-model-tqxkp6xb1h"
        
              ~ primary_container {
                    environment = {
                        "foo" = "bar"
                    }
                    image       = "174872318107.dkr.ecr.us-west-2.amazonaws.com/kmeans:1"
                  - mode        = "SingleModel" -> null
                }
            }

mode needs to be set as default for SingleModel.

updated the default value and its passing now.

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModel_primaryContainerEnvironment -timeout 120m
=== RUN TestAccAWSSagemakerModel_primaryContainerEnvironment
=== PAUSE TestAccAWSSagemakerModel_primaryContainerEnvironment
=== CONT TestAccAWSSagemakerModel_primaryContainerEnvironment
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (62.52s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 65.492s

[DrFaust92]

@nikhil-goenka lets also add the its the default value the the docs.

[nikhil-goenka]

@nikhil-goenka lets also add the its the default value the the docs.

already done

[DrFaust92]

Missed it 😅 . running tests now.

[DrFaust92]

LGTM

--- PASS: TestAccAWSSagemakerModel_networkIsolation (57.62s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (58.01s)
--- PASS: TestAccAWSSagemakerModel_basic (61.42s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModeSingle (61.54s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (62.15s)
--- PASS: TestAccAWSSagemakerModel_containers (76.41s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (84.87s)
--- PASS: TestAccAWSSagemakerModel_tags (87.15s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (96.73s)

[bflad]

Looks good, thanks @nikhil-goenka 🚀

Output from acceptance testing (tags testing previously flaky and unrelated):

--- FAIL: TestAccAWSSagemakerModel_tags (25.48s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (35.25s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModeSingle (36.71s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (46.65s)
--- PASS: TestAccAWSSagemakerModel_basic (48.03s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (50.85s)
--- PASS: TestAccAWSSagemakerModel_containers (52.39s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (53.36s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (54.68s)

[ghost]

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!