Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Debt Theme: Resolve Acceptance Test Failures (Workspaces) #14950

Closed
3 tasks
anGie44 opened this issue Sep 1, 2020 · 2 comments
Closed
3 tasks

Technical Debt Theme: Resolve Acceptance Test Failures (Workspaces) #14950

anGie44 opened this issue Sep 1, 2020 · 2 comments
Labels
service/workspaces Issues and PRs that pertain to the workspaces service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@anGie44
Copy link
Contributor

anGie44 commented Sep 1, 2020

Description

This is a meta-issue which tracks the list of Workspaces Acceptance Tests which now consistently fail. The August-October 2020 Roadmap for the AWS Provider includes a technical debt theme which decides an area of debt upon which we want to apply focus.

The focus for this period is improving our Acceptance Test suite. This covers resolving failing and flaky tests. Our initial focus will be to resolve failing tests which exist within our Core Service list.

Workspaces Tests Currently Failing

  • TestAccAWSWorkspacesWorkspace_tags

Workspaces Tests Occasionally Failing

  • TestAccAwsWorkspacesWorkspace_workspaceProperties_runningModeAlwaysOn
  • TestAccAwsWorkspacesWorkspace_workspaceProperties

Example Test Output:

TestAccAwsWorkspacesWorkspace_tags: testing_new.go:22: WARNING: destroy failed, so remote objects may still exist and be subject to billing
    TestAccAwsWorkspacesWorkspace_tags: testing_new.go:22: failed to destroy: terraform failed: exit status 1
        
        stderr:
        
        Error: workspace "ws-123abc" was not terminated: couldn't find resource (21 retries)
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Sep 1, 2020
@bflad bflad added service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 1, 2020
@bflad bflad added this to the Roadmap milestone Sep 1, 2020
@anGie44
Copy link
Contributor Author

anGie44 commented Sep 24, 2020

Closing as issue can be tracked in #15190

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
@breathingdust breathingdust removed this from the Roadmap milestone Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/workspaces Issues and PRs that pertain to the workspaces service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

No branches or pull requests

3 participants