Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_configuration_set - add arn attribute #13972

Merged
merged 9 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 27, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624

Release note for CHANGELOG:

resource_aws_ses_configuration_set: add arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSESConfigurationSet_'
--- PASS: TestAccAWSSESConfigurationSet_disappears (27.11s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (36.51s)
--- PASS: TestAccAWSSESConfigurationSet_basic (36.76s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (36.76s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (84.56s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (107.29s)

@DrFaust92 DrFaust92 requested a review from a team June 27, 2020 19:38
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 27, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jul 25, 2020
@DrFaust92 DrFaust92 requested a review from a team as a code owner November 12, 2020 17:58
@DrFaust92 DrFaust92 force-pushed the r/ses_configuration_set branch from ff86700 to 1879ba7 Compare November 12, 2020 18:52
Base automatically changed from master to main January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/ses_configuration_set branch from 1879ba7 to 64ec460 Compare February 11, 2021 14:59
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 11, 2021
@YakDriver YakDriver self-assigned this Feb 11, 2021
@YakDriver YakDriver force-pushed the r/ses_configuration_set branch from 2e568a4 to f8bc7ec Compare February 11, 2021 17:10
@DrFaust92 DrFaust92 force-pushed the r/ses_configuration_set branch from f8bc7ec to 6ca3396 Compare February 11, 2021 17:37
@YakDriver YakDriver force-pushed the r/ses_configuration_set branch from 6ca3396 to e555401 Compare February 11, 2021 17:39
@DrFaust92 DrFaust92 force-pushed the r/ses_configuration_set branch from e555401 to d103684 Compare February 11, 2021 17:40
@YakDriver YakDriver force-pushed the r/ses_configuration_set branch 2 times, most recently from e555401 to aeea3e4 Compare February 11, 2021 17:44
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

GovCloud:

--- PASS: TestAccAWSSESConfigurationSet_disappears (13.80s)
--- PASS: TestAccAWSSESConfigurationSet_basic (17.70s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (18.10s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (18.11s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (41.55s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (52.17s)

us-west-2:

--- PASS: TestAccAWSSESConfigurationSet_disappears (10.96s)
--- PASS: TestAccAWSSESConfigurationSet_basic (13.39s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (14.00s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (14.05s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (31.15s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (39.08s)

@YakDriver YakDriver force-pushed the r/ses_configuration_set branch from aeea3e4 to a138cd0 Compare February 11, 2021 17:54
@YakDriver YakDriver added this to the v3.28.0 milestone Feb 11, 2021
@YakDriver YakDriver merged commit 4e70bcf into hashicorp:main Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/ses_configuration_set branch April 15, 2021 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants