Updating a file pointed to in aws_emr_cluster.configurations should trigger instance recreation

[synhershko]

E.g.

resource "aws_emr_cluster" "querying" {
  name          = "Querying"
  release_label = "emr-5.7.0"
  applications  = ["Hadoop", "Hive", "Presto", "Ganglia"]

  configurations = "querying-emr-configurations.json"

  master_instance_type = "m4.large"
  core_instance_type   = "m4.2xlarge"
  core_instance_count  = 2
}

Updating the file querying-emr-configurations.json isn't detected and doesn't trigger new instance creation while it should.

Using v0.10.0

[bflad]

The configurations attribute is quite an odd implementation in this older resource. Its taking in a file path/URL as an input while the API only ever would know how to return the JSON content. There are two issues here:

• During the resource read function, this attribute is never getting set into the Terraform state properly (the d.Set() call for it will always fail with trying to write the wrong []*emr.Configuration type as schema.TypeString)
• Even if we fix the above, we cannot detect drift between the original input (a file path or URL) and what the API returns (JSON content)

It seems like the configurations attribute needs to be deprecated and a new attribute (configurations_json?) created that properly only accepts JSON input so it can be properly compared to what the API returns.

[bflad]

Related: #543, which would also be fixed with JSON <-> JSON attribute (as it wouldn't matter where the content was coming from to Terraform).

[bflad]

Version 1.30.0 of the AWS provider, releasing later today, will have a new configurations_json argument that accepts the actual JSON contents and can correctly determine drift from the EMR API. In an upcoming release we'll mark the existing configurations argument as deprecated.

To convert to the new attribute, given this Terraform configuration:

resource "aws_emr_cluster" "example" {
  # ... other configuration ...
  configurations = "example.json"
}

Update it to:

resource "aws_emr_cluster" "example" {
  # ... other configuration ...
  configurations_json = "${file("example.json")}"
}

[bflad]

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!