Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Issues with tor-0.4.8.13 release #1195

Open
syphyr opened this issue Oct 31, 2024 · 3 comments
Open

[Feature Request] Issues with tor-0.4.8.13 release #1195

syphyr opened this issue Oct 31, 2024 · 3 comments
Assignees

Comments

@syphyr
Copy link
Contributor

syphyr commented Oct 31, 2024

When updating to tor-0.4.8.13, there is an issue with Orbot crashing when restarting the tor daemon. Please see the following issue: https://gitlab.torproject.org/tpo/core/tor/-/issues/40989

This issue described above with tor-0.4.8.13 has been fixed with the following commit: https://gitlab.torproject.org/tpo/core/tor/-/commit/4759350b9a020d735506479e2d51c76d38566017

Also, the following commit to tor can probably now be excluded since this cleanup feature is now included in the official tor source:
guardianproject/tor@6714d2d

@n8fr8
Copy link
Member

n8fr8 commented Nov 1, 2024

Thanks for the concise description!

@n8fr8
Copy link
Member

n8fr8 commented Dec 30, 2024

@uniqx not sure this was included in the last update you did to 0.4.8.13. I am experiencing the crash mentioned.

@uniqx
Copy link
Member

uniqx commented Jan 7, 2025

@uniqx not sure this was included in the last update you did to 0.4.8.13. I am experiencing the crash mentioned.

It wasn't included. That's because currently it's only available in Tor 0.4.9-aplha branch.

I guess cherry picking it into our 0.4.8 branch and treat it like an android specific change should be fine, not sure if moving to alpha is a great idea but would also deliver that fix.

I could do a build with the cherry-picked fix. It seems to compile just fine. (However I seem to experience an issue with tor-android where it doesn't package .so files into the .aar. I was following these docs: https://raw.githubusercontent.com/guardianproject/tor-android/master/BUILD.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants