Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on Code Redundancy in EC2 VPC #681

Closed
james03160927 opened this issue Apr 16, 2024 · 0 comments
Closed

Improvement on Code Redundancy in EC2 VPC #681

james03160927 opened this issue Apr 16, 2024 · 0 comments
Assignees

Comments

@james03160927
Copy link
Contributor

We created the following resources that relates to EC2 VPC:

  • internet Gateways
  • EgressOnly internet Gateways
  • Endpoints
  • NetworkInterfaces
  • Subnets
  • Nacls
  • SecurityGroups
  • DHCP options

RIght now, there seems to be quite a lot of code redundancy. Pretty much similar code exist in ec2_vpc.go and all the new resources. We need to update the code something like this: #680

Also, we need to control checking default vs. non-default identifiers for the following functions:

  • nukeNacls
  • nukeDhcpOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant