Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install from a venv ends up with unrelocated -I flags when rebuilding wheels #29

Open
mathstuf opened this issue Oct 2, 2022 · 2 comments

Comments

@mathstuf
Copy link
Contributor

mathstuf commented Oct 2, 2022

Seen in this build:

clang -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -arch arm64 -arch x86_64 -g -I/opt/glr/vtk/vtk-ci-ext/0/venv/include -I/Library/Frameworks/Python.framework/Versions/3.11/include/python3.11

The -I/Library/Frameworks needs relocated.

@mathstuf
Copy link
Contributor Author

mathstuf commented Oct 2, 2022

This probably requires smarter logic in…something. Not sure if CPython, pip, or setuptools needs to get smarter or not.

@mathstuf
Copy link
Contributor Author

mathstuf commented Oct 2, 2022

A grep of my repackage of the relocatable install shows Python.framework/Versions/3.11/lib/python3.11/_sysconfigdata__darwin_darwin.py having hardcoded paths :/ . Other paths with hardcodings that may be relevant:

  • Python.framework/Versions/3.11/lib/python3.11/config-3.11-darwin/python-config.py
  • Python.framework/Versions/3.11/lib/python3.11/config-3.11-darwin/Makefile
  • Python.framework/Versions/3.11/lib/pkgconfig/python-3.11.pc
  • Python.framework/Versions/3.11/lib/pkgconfig/python-3.11-embed.pc

as well as various Tcl/Tk bits. The .pc files could probably just use $prefix detection instead of forcing things. The rest…all seems Darwin-specific and probably too hard to change while being as "reliable" as it is today. I guess we'll just have to wait for 3.11 wheels to be provided by others for our CI to be happy (our code uses CMake which skips all of this hard-coded stuff, so we've just been skating by).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant