Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible backend code changes for more SDK features #74

Open
kylebrandt opened this issue Apr 3, 2020 · 1 comment
Open

Possible backend code changes for more SDK features #74

kylebrandt opened this issue Apr 3, 2020 · 1 comment
Labels
type/chore Chores, code refactoring or maintenance work

Comments

@kylebrandt
Copy link
Contributor

  • pkg/googlesheets/utils.go findTimeField can be frame.TypeIndices(data.FieldTypeTime, data.FieldTypeNullableTime)` instead
  • pkg/googlesheets/utils.go frame.Fields[columnIndex].Set(rowIndex-start, &cellData.FormattedValue) can be frame.Set(columnIndex, rowIndex-start, &cellData.FormattedValue) if you like.
  • pkg/googlesheets/utils.go getUniqueColumnName - frame Field names no longer need to be unique within a Frame. So if this is why this is there, it can be removed.
@zoltanbedi zoltanbedi added the type/chore Chores, code refactoring or maintenance work label Feb 28, 2024
@zoltanbedi
Copy link
Member

As far as I see what's left is the getUniqueColumnName function we can revisit this.

@zoltanbedi zoltanbedi moved this to Backlog in OSS Big Tent Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/chore Chores, code refactoring or maintenance work
Projects
OSS Big Tent
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylebrandt @zoltanbedi