From f4b1c498dad3004fd051052bd7b8cb896568ad8c Mon Sep 17 00:00:00 2001 From: Chalmer Date: Mon, 3 Apr 2023 19:12:37 +0000 Subject: [PATCH 1/3] chore: updates minimum version of bqstorage --- setup.py | 2 +- testing/constraints-3.7.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 51cb6dc75..08106f694 100644 --- a/setup.py +++ b/setup.py @@ -51,7 +51,7 @@ # Keep the no-op bqstorage extra for backward compatibility. # See: https://github.com/googleapis/python-bigquery/issues/757 "bqstorage": [ - "google-cloud-bigquery-storage >= 2.0.0, <3.0.0dev", + "google-cloud-bigquery-storage >= 2.6.0, <3.0.0dev", # Due to an issue in pip's dependency resolver, the `grpc` extra is not # installed, even though `google-cloud-bigquery-storage` specifies it # as `google-api-core[grpc]`. We thus need to explicitly specify it here. diff --git a/testing/constraints-3.7.txt b/testing/constraints-3.7.txt index c94d80abf..2ea482e8b 100644 --- a/testing/constraints-3.7.txt +++ b/testing/constraints-3.7.txt @@ -8,7 +8,7 @@ db-dtypes==0.3.0 geopandas==0.9.0 google-api-core==1.31.5 -google-cloud-bigquery-storage==2.0.0 +google-cloud-bigquery-storage==2.6.0 google-cloud-core==1.6.0 google-resumable-media==0.6.0 grpcio==1.47.0 From f30f3efe4d46a63f5461647518fa81940ac1bd46 Mon Sep 17 00:00:00 2001 From: Chalmer Date: Mon, 3 Apr 2023 20:26:44 +0000 Subject: [PATCH 2/3] removes unneeded test --- tests/unit/job/test_query_pandas.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/job/test_query_pandas.py b/tests/unit/job/test_query_pandas.py index a2444efdd..ca46c602b 100644 --- a/tests/unit/job/test_query_pandas.py +++ b/tests/unit/job/test_query_pandas.py @@ -62,8 +62,8 @@ def table_read_options_kwarg(): # Create a BigQuery Storage table read options object with pyarrow compression # enabled if a recent-enough version of google-cloud-bigquery-storage dependency is # installed to support the compression. - if not hasattr(bigquery_storage, "ArrowSerializationOptions"): - return {} + #if not hasattr(bigquery_storage, "ArrowSerializationOptions"): + # return {} read_options = bigquery_storage.ReadSession.TableReadOptions( arrow_serialization_options=bigquery_storage.ArrowSerializationOptions( From e2cf86ccd5ba9b80cfb6d7bbfaeeba2bdcc236e7 Mon Sep 17 00:00:00 2001 From: Chalmer Date: Tue, 4 Apr 2023 13:26:35 +0000 Subject: [PATCH 3/3] updates linting, removes unneeded comment --- tests/unit/job/test_query_pandas.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/unit/job/test_query_pandas.py b/tests/unit/job/test_query_pandas.py index ca46c602b..01b60ceb3 100644 --- a/tests/unit/job/test_query_pandas.py +++ b/tests/unit/job/test_query_pandas.py @@ -59,12 +59,6 @@ @pytest.fixture def table_read_options_kwarg(): - # Create a BigQuery Storage table read options object with pyarrow compression - # enabled if a recent-enough version of google-cloud-bigquery-storage dependency is - # installed to support the compression. - #if not hasattr(bigquery_storage, "ArrowSerializationOptions"): - # return {} - read_options = bigquery_storage.ReadSession.TableReadOptions( arrow_serialization_options=bigquery_storage.ArrowSerializationOptions( buffer_compression=bigquery_storage.ArrowSerializationOptions.CompressionCodec.LZ4_FRAME