-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edit presubmit for to simplify configuration #1915
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Using base names in the config file works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the title here seems out of sync with the changes, but I may be missing some context. It appears to simply be an update to the existing config, not a new one.
This creates a new cfg that could be used in place of the existing kokoro presubmit test.
The intent here is to avoid using variables to skip certain nox sessions and simply call the nox sessions that we want to execute. The benefit is that...because nox sessions create the virtual env before they execute the session steps, we end up needlessly creating virtual envs for sessions that we end up skipping when we reach the skip/not skip logic.