-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Propagate command line arguments #35
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
- Coverage 73.72% 29.31% -44.41%
===========================================
Files 4 4
Lines 1511 1511
===========================================
- Hits 1114 443 -671
- Misses 397 1068 +671
Continue to review full report at Codecov.
|
fixes #36 |
an you write a test which fails before, but now passes? |
unfortunately, it is quite difficult to test this, because it's a command line feature which requires human interaction (auth flow). Briefly, it only happens when the file I am not sure of the best way to test this interaction. |
ok can u add an entry in the changelog.rst |
fdc763b
to
44aa7e8
Compare
This worked as expected in my limited testing locally. Without the fix, I received the following message with
Here is my output with the fix. Notice that the message changed from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @lfiaschi !
The command line arguments were not correctly propagated, which do not allowed using flags as
--noauth_local_webserve
. This seems to fix the issue and now the flag is correctly passed downstream.