-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip installing jaxlib 0.1.63 fails on Mac OS #6111
Comments
Thanks for the report - I can reproduce this on OSX 10.15. Installation on ubuntu is fine, so it appears to be specific to the OSX wheels. @skye can you take a look? |
Oof, after lovingly fixing this error and building new release wheels, I uploaded the old broken wheels! 🤦♀️ I don't think pypi lets you upload new wheels for a given release, but I missed something else in the 0.1.63 release anyway so am gonna cut a 0.1.64 soon (like tomorrow). So I recommend sticking to 0.1.62 for now, and upgrading to 0.1.64 once it's available (I can close this issue when that happens). |
Thanks very much for the quick diagnosis, @skye! Super appreciated, and I think everyone's been there before with a PyPI upload mishap. :)
No, they don't, but can you please also yank I'm also don't know how Google operates when it comes to the building and releasing of wheels, but unless there is some bespoke in-house workflow and procedure I'd highly recommend |
I'd also list some happy users: https://cibuildwheel.readthedocs.io/en/stable/working-examples/ :) You can do a post1 release, perhaps? |
I hadn't heard of yanking a release (or post1 releases, or cibuildwheel, for that matter), thanks for the suggestions! I just yanked 0.1.63 and am working on a 0.1.64 release now. I think @hawkinsp set up most of our Python packaging and to be honest I don't know much about Python packaging in general, so it's hard for me to say if Stupid beginner Q: how does |
Awesome! That means everyone's CI is working again. 🎉 Yeah, PEP 592 is still not super widely known about in general it seems, but very helpful!
I'll let the |
You can use cibuildwheel on custom hardware, too. The only reason it's not recommended for local use is that it installs Python into global locations on macOS and Windows, but any virtualized or runner hardware should be absolutely fine. If it's not a known CI, you might want to set Personally I recommend getting as close to being able to install from SDist as possible and using pyproject.toml from PEP 517/518. Then it should work "out of the box" except for whatever you were not able to do as part of that process, which you then can put in the above mentioned variables (say as a script or install commands, etc). |
I think this is the key piece I didn't know about :) We're not set up to build that way. Instead, we have a build script that configures bazel (e.g. whether to link in CUDA support, where CUDA is installed, etc.), then uses bazel to build the required C++ dependencies, and finally invokes another script as part of the same BUILD rule that uses I still don't really know how things needs to be structured such that BTW, y'all have been so kind and helpful! So even if this thread isn't worth pulling now, thanks for all the tips and advice so far. |
One other comment is that we need a very unusual toolchain to build C++14 code that is manylinux2010 compliant. And we do that in an unusual Docker container. So I don't hold great hopes of make the |
You could see this project https://github.com/czaki/imagecodecs_build And cibuildwheel use manylinux compatible containers during build linux wheel. |
Oops, forgot to close this issue, but |
Upgrading from jaxlib 0.1.62 to 0.1.63 causes import of jax to fail with mysterious error messages. Downgrading back to 0.1.62 and everything is happy again. (This in on Mac OS)
The text was updated successfully, but these errors were encountered: