Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to set volume greater than 1.0f (amplification) #3657

Closed
devnullpointer opened this issue Jan 2, 2018 · 2 comments
Closed
Assignees

Comments

@devnullpointer
Copy link

Issue description

Is it possible to set the volume in exoplayer to a value greater than 1.0f to create an "amplification" effect for videos that have been recorded with low audio levels?

Reproduction steps

  1. add a seekbar in the overriden exo_playback_control_view
  2. add the following onseekbarchangelistener in the player activity
seekBar.setMax(200);
seekBar.setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener()
        {
            @Override
            public void onProgressChanged(final SeekBar seekBar, final int progress, final boolean fromUser)
            {
                final float adjust = (float) progress / 100;
                Log.d(TAG, "Volume: " + adjust);
                player.setVolume(adjust);
            }

            @Override
            public void onStartTrackingTouch(final SeekBar seekBar)
            {
            }

            @Override
            public void onStopTrackingTouch(final SeekBar seekBar)
            {
            }
        });

Any volume level greater than 1.0f has no audio effect, lower than 1.0 will reduce the volume.

Version of ExoPlayer being used

2.6.0

Device(s) and version(s) of Android being used

Android KitKat 4.4

@andrewlewis
Copy link
Collaborator

It should be possible to implement this kind of postprocessing via a custom AudioProcessor. Marking as an enhancement for now, but it's unlikely we will get round to it soon. Feel free to send a PR.

@andrewlewis
Copy link
Collaborator

Marking as a duplicate of #2659 as that is also a request for a volume controlling AudioProcessor.

@google google locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants