Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concent VM: Move configuration env variables to config.yml #363

Open
cameel opened this issue Mar 15, 2019 · 0 comments
Open

Concent VM: Move configuration env variables to config.yml #363

cameel opened this issue Mar 15, 2019 · 0 comments

Comments

@cameel
Copy link
Contributor

cameel commented Mar 15, 2019

In #278 we added concent-vm/config.yml. At the time when that issue was defined the intention was to move all the configuration to that file. #332 added a lot of new variables and those were not handled in #278. They should be added to config.yml too.

  • For each variable add an entry in config.yml. Make it lower case.
  • Load values from config.yml in Vagrantfile.
  • Remove support for the current variables.
  • Update README.
  • Provide a template file with defaults that can be used as a starting point by someone configuring the machine.

If processing YAML in Vagrantfile turns out to be complicated (e.g. if it requires installing extra Ruby packages) we can also discuss alternative solutions. E.g. keeping the variables and just putting them in a file to be sourced by the Vagrantfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant