From 9bf48fc971e39c37dfd49db739b219f124c79962 Mon Sep 17 00:00:00 2001 From: "Hana (Hyang-Ah) Kim" Date: Wed, 18 Mar 2020 18:11:05 +0000 Subject: [PATCH] github/workflows: use npm install and change version to X.Y.Z format semver package is unhappy about X.Y.Z.W format of version string and leave the extension in invalid state. Now make semver happy. Also, use npm install to ensure all test dependencies are pulled in. --- .github/workflows/release.yml | 2 +- build/all.bash | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 809a829194..eff44f1d1c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,7 +34,7 @@ jobs: go-version: '1.14' - name: Install dependencies - run: npm ci + run: npm install - name: Install Go tools (Modules mode) run: | diff --git a/build/all.bash b/build/all.bash index 57fe5122f7..476962e29c 100755 --- a/build/all.bash +++ b/build/all.bash @@ -52,7 +52,10 @@ run_test_in_docker() { } prepare_nightly() { - local VER=`git log -1 --format=%cd --date="format:%Y.%-m.%-d.%-H"` + # Version format: YYYY.MM.DDHH based on the latest commit timestamp. + # e.g. 2020.1.510 is the version built based on a commit that was made + # on 2020/01/05 10:00 + local VER=`git log -1 --format=%cd --date="format:%Y.%-m.%-d%H"` local COMMIT=`git log -1 --format=%H` echo "**** Preparing nightly release : $VER ***"