Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflect: undeprecate SliceHeader, StringHeader #56905

Closed
rsc opened this issue Nov 22, 2022 · 1 comment
Closed

reflect: undeprecate SliceHeader, StringHeader #56905

rsc opened this issue Nov 22, 2022 · 1 comment
Assignees
@rsc
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.20

Comments

@rsc
Copy link
Contributor

rsc commented Nov 22, 2022

If SliceHeader and StringHeader are to be deprecated, that should go through the proposal process.

Also, per https://go.dev/wiki/Deprecated, the deprecation cannot happen until Go 1.22, since their replacements are only being added in Go 1.20.

CL 452761 removes the notices.
CL 452672 restores them, for after the proposal.
@rsc rsc added this to the Go1.20 milestone Nov 22, 2022
@rsc rsc self-assigned this Nov 22, 2022
@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Nov 22, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 22, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/452761 mentions this issue: reflect: remove deprecation notices from SliceHeader, StringHeader

@golang golang locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rsc rsc

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
2 participants
@rsc @gopherbot