You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The load button has been removed from the EditorResourcePicker in a previous PR to favor a new quick-load button located right next to the arrow.
This can be convenient in lots of cases however :
This is not suitable for all users due to accessibility issues.
In the cases where a lot of files are listed, the quick load is limited to only 100 search occurrences which can be a problem with a lot of repetitive asset names (for instance portrait_XXX.png)
Some people just prefer navigating the folder structure and avoid using the quick load menu.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
The problem could be solved in two ways :
Simply bringing back the load button at the bottom of the list as it was before.
Allow for the configuration in the editor of which load menu is used when clicking the button.
I personally prefer the second option as it continues with the current flow of improvement, but also does not feel like a regression for people struggling with the new system.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
For option no1 we can simply revert part of the commit df01daf to re-include the "basic" load menu at the bottom of the list.
For option no2 I propose we proceed as follows :
We add an enum in the EditorResourcePicker (L65) class defining which load menu is used for the resource picker :
We add a test in the _load_button_pressed method of EditorResourcePicker (L184) to choose which dialog to open when the button is clicked :
auto load_dialog_mode = (LoadDialogMode)(int)EDITOR_GET("interface/inspector/resource_picker_load_dialog_mode");
if (load_dialog_mode == QUICK_LOAD) {
[... Do quick load ...]
}
else {
[... Do standard load ...]
}
We add documentation for the new settings.
Of course I'm voluntary for the corresponding PR if the proposal is accepted.
If this enhancement will not be used often, can it be worked around with a few lines of script?
This can be edited of course by people in their own forks, but this is clearly not ideal. Quick load is really useful as far as I am concerned, but I think the choice between quick and slow load should not be imposed on the user in that way.
Is there a reason why this should be core and not an add-on in the asset library?
This is part of the editor, so I believe it should be core.
The text was updated successfully, but these errors were encountered:
mdelorme
changed the title
Allowing customisation of which load menu is used in EditorResourcePicker
Allowing customization of which load menu is used in EditorResourcePickerJan 6, 2025
Describe the project you are working on
Various projects, but mainly a narrative puzzle game.
Describe the problem or limitation you are having in your project
Following the discussions on #101183
The load button has been removed from the
EditorResourcePicker
in a previous PR to favor a new quick-load button located right next to the arrow.This can be convenient in lots of cases however :
portrait_XXX.png
)Describe the feature / enhancement and how it helps to overcome the problem or limitation
The problem could be solved in two ways :
I personally prefer the second option as it continues with the current flow of improvement, but also does not feel like a regression for people struggling with the new system.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
For option no1 we can simply revert part of the commit df01daf to re-include the "basic" load menu at the bottom of the list.
For option no2 I propose we proceed as follows :
EditorResourcePicker (L65)
class defining which load menu is used for the resource picker :enum LoadDialogMode { QUICK_LOAD, DEFAULT_LOAD };
editor_settings.cpp
to account for this :_load_button_pressed
method ofEditorResourcePicker (L184)
to choose which dialog to open when the button is clicked :Of course I'm voluntary for the corresponding PR if the proposal is accepted.
If this enhancement will not be used often, can it be worked around with a few lines of script?
This can be edited of course by people in their own forks, but this is clearly not ideal. Quick load is really useful as far as I am concerned, but I think the choice between quick and slow load should not be imposed on the user in that way.
Is there a reason why this should be core and not an add-on in the asset library?
This is part of the editor, so I believe it should be core.
The text was updated successfully, but these errors were encountered: