Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several crashes when running with fuzzer #868

Closed
qarmin opened this issue May 24, 2024 · 1 comment · Fixed by #871
Closed

Several crashes when running with fuzzer #868

qarmin opened this issue May 24, 2024 · 1 comment · Fixed by #871
Labels
bug Something that isn't working as intended severity:minor Small impact on functionality or usability topic:runtime Concerning runtime behavior (or its source code)

Comments

@qarmin
Copy link

qarmin commented May 24, 2024

Steps to reproduce:

######################################## JoltJointGizmoPlugin3D ########################################
ERROR: Class 'EditorNode3DGizmoPlugin' can only be instantiated by editor.
   at: instantiate (core/object/class_db.cpp:364)
ERROR: Parameter "p_object" is null.
   at: set_object_extension_instance (core/object/class_db.cpp:382)

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.2.stable.official (15073afe3856abd2aa1622492fe50026c7d63dc1)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x45320) [0x7e7bc8845320] (??:0)
[2] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x3b3c6b6] (??:0)
[3] /home/rafal/Projekty/Godot/Qarminer/addons/godot-jolt/linux/godot-jolt_linux-x64_editor.so(+0x39d9bf) [0x7e7bc1d9d9bf] (??:0)
[4] /home/rafal/Projekty/Godot/Qarminer/addons/godot-jolt/linux/godot-jolt_linux-x64_editor.so(+0x29f0fa) [0x7e7bc1c9f0fa] (??:0)
[5] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x3b51123] (??:0)
[6] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x36cc2df] (??:0)
[7] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x15548e2] (??:0)
[8] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x72e1f9] (??:0)
[9] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x6283d1] (??:0)
[10] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x3b51f3f] (??:0)
[11] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x39dee2f] (??:0)
[12] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x72b454] (??:0)
[13] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x6283d1] (??:0)
[14] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x209a9a2] (??:0)
[15] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x3b3a578] (??:0)
[16] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x2091204] (??:0)
[17] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x209260b] (??:0)
[18] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x2095ee1] (??:0)
[19] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x4f877d] (??:0)
[20] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x41e8b8] (??:0)
[21] /lib/x86_64-linux-gnu/libc.so.6(+0x2a1ca) [0x7e7bc882a1ca] (??:0)
[22] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x8b) [0x7e7bc882a28b] (??:0)
[23] /home/rafal/Downloads/Godot_v4.2.2-stable_linux.x86_64() [0x42a59a] (??:0)
-- END OF BACKTRACE --
================================================================

RigidBody3D.set_max_contacts_reported --- executing with 1 parameters [-24]
	temp_variable429.set_max_contacts_reported(-24)
terminate called after throwing an instance of 'std::length_error'
  what():  vector::_M_default_append
Aborted (core dumped)

for tests, classes can be disabled entirely in file BasicData.gd inside disabled_classes variable

I don't have build with sanitizers, but probably more errors could be found with its help

@github-actions github-actions bot added the needs triage Something that needs investigation label May 24, 2024
@mihe mihe added bug Something that isn't working as intended topic:runtime Concerning runtime behavior (or its source code) severity:minor Small impact on functionality or usability and removed needs triage Something that needs investigation labels May 24, 2024
@mihe
Copy link
Contributor

mihe commented May 24, 2024

That's pretty neat!

That first crash actually looks to be a bug in Godot itself, where ClassDB::can_instantiate only checks against API_EDITOR and not API_EDITOR_EXTENSION. I'll see about making a PR to fix that.

That second one is definitely my fault though.

@mihe mihe changed the title Several crashes when running addon with test project Several crashes when running with fuzzer May 24, 2024
@mihe mihe closed this as completed in #871 May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended severity:minor Small impact on functionality or usability topic:runtime Concerning runtime behavior (or its source code)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants