moda-ci.yaml triggers an error in forks for anyone who doesn't have access to github/docs-internal

[jsoref]

This guard

docs/.github/workflows/moda-ci.yaml

Line 39 in 190a7a5

if: ${{ github.repository == 'github/docs-internal' }}

did not prevent:
Invalid workflow file: .github/workflows/moda-ci.yaml#L86

error parsing called workflow
".github/workflows/moda-ci.yaml"
-> "github/internal-actions/.github/workflows/docker_security.yml@main"
: workflow was not found. See https://docs.github.com/actions/learn-github-actions/reusing-workflows#access-to-reusable-workflows for more information.

I think it might be possible to avoid this structure by using a combination of a workflow_call with a jobs: / if: condition that guards against the user from tripping on the problem e.g. ${{ github.repository == 'github/docs-internal' }} and then have the on: workflow_call on the internal side be responsible for using the reusable workflow.

Originally posted by @jsoref in #34562 (comment)

[nguyenalex836]

@jsoref Thank you for raising the flag on this! ✨ Given the referenced file, I'll create an issue to have this reviewed internally 💛

I'll close this issue, but if you find anything else that might be relevant, feel free to ping me here and I'll copy over to the internal issue!

[docs-bot]

Thank you for opening this issue! Updates to this documentation must be made internally. I have copied your issue to an internal issue, so I will close this issue.