Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should now install it globally if it is installed? #3

Open
tunnckoCore opened this issue Sep 11, 2016 · 1 comment
Open

Should now install it globally if it is installed? #3

tunnckoCore opened this issue Sep 11, 2016 · 1 comment
Labels

Comments

@tunnckoCore
Copy link

tunnckoCore commented Sep 11, 2016

I think it should not install it again if it exists and is same version/range. Applies for global specifically.

I have verb and verb-generate-readme installed globally and have this front matter

---
install:
  global: [
    "verbose/verb#dev",
    "verb-generate-readme"
  ]
  dependencies: ["lazy-cache"]
  devDependencies: [
    "commitizen",
    "coveralls",
    "cz-conventional-changelog",
    "husky",
    "mukla",
    "nyc",
    "standard",
    "standard-version",
    "validate-commit-msg"
  ]

---
// package.json ...

and outputs

[00:12:02] starting default:install task 
/home/charlike/.nvm/versions/node/v6.3.0/bin/verb -> /home/charlike/.nvm/versions/node/v6.3.0/lib/node_modules/verb/bin/verb.js
/home/charlike/.nvm/versions/node/v6.3.0/lib
├─┬ [email protected]  (git://github.com/verbose/verb.git#20f8a0d36e57a57a3b2faa7a6eea85e3aee4eaa0)
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │   └─┬ [email protected]
│ │     └── [email protected]  (git://github.com/jonschlinkert/resolve-file.git#261082c95a5f407c43d82797c13bae3527462842)
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └── [email protected]  (git://github.com/matthewmueller/date.git#a495343a3bf38546978dfecafedbc78b9bf87573)
└─┬ [email protected] 
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └── [email protected]  (git://github.com/matthewmueller/date.git#a495343a3bf38546978dfecafedbc78b9bf87573)

with highlighted date.js

@jonschlinkert
Copy link
Member

Huh, I totally forgot we implemented global, nice.

I agree totally. That would be pretty frustrating, especially if it overwrote custom code. marking as a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants