Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested Improvement - Don't move or modify input file #1

Open
markjschreiber opened this issue Nov 5, 2021 · 0 comments
Open

Suggested Improvement - Don't move or modify input file #1

markjschreiber opened this issue Nov 5, 2021 · 0 comments

Comments

@markjschreiber
Copy link

In the workflow an input file is moved to another location. Not exactly a bug (except in miniwdl where you are not allowed to do this). But it can be hazardous because other steps in a workflow might expect the file to still be there (especially scatters).

The line:

mv ~{input_file} ~{new_name}

would be better as

cp ~{input_file} ~{new_name}

In general it would be safer to avoid making any changes to the location or content of an input if you can.

Happy to submit a PR if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant