This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Request ID #392
Merged
Request ID #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gambol99
commented
Jul 10, 2018
gambol99
commented
- adding a request id middleware injection via the --enable-request-id
- fixing up the Makefile
jangaraj
reviewed
Jul 10, 2018
middleware.go
Outdated
| return func(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { | ||
| if v := req.Header.Get(header); v == "" { | ||
| req.Header.Set(header, randomString(length)) |
There was a problem hiding this comment.
Why do we need randomString? IMHO better option is to use some UUID library - maybe github.com/google/uuid, also caddy uses it: https://github.com/mholt/caddy/blob/master/caddyhttp/requestid/requestid.go
There was a problem hiding this comment.
[jest@starfury keycloak-proxy]$ make bench
--> Running go bench
goos: linux
goarch: amd64
pkg: github.com/gambol99/keycloak-proxy
BenchmarkRandomBytes36-8 10000000 146 ns/op 96 B/op 2 allocs/op
BenchmarkRandomString36-8 10000000 148 ns/op 96 B/op 2 allocs/op
# using google uuid
BenchmarkUUID-8 1000000 1183 ns/op 16 B/op 1 allocs/op
# using a random string
BenchmarkRandomUUID-8 10000000 187 ns/op 80 B/op 2 allocs/op
BenchmarkEncryptDataBlock-8 1000000 2303 ns/op 1200 B/op 7 allocs/op
BenchmarkEncodeText-8 500000 3262 ns/op 2352 B/op 11 allocs/op
BenchmarkDecodeText-8 1000000 1907 ns/op 2208 B/op 10 allocs/op
BenchmarkContainsSubString-8 200000000 7.95 ns/op 0 B/op 0 allocs/op
PASS
ok github.com/gambol99/keycloak-proxy 17.928s
Running both with a 36 character length, it's 10x slower
There was a problem hiding this comment.
basically i got bored and started messing about and saved 1000ns :-)
There was a problem hiding this comment.
👍 Could you try https://github.com/edwingeng/wuid, pls?
- adding a request id middleware injection via the --enable-request-id - fixing up the Makefile
…one, lose 20ns but hey :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.