Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Toaster notification code out of onSaveToServer #6

Open
cpina opened this issue Oct 27, 2020 · 0 comments
Open

Move Toaster notification code out of onSaveToServer #6

cpina opened this issue Oct 27, 2020 · 0 comments

Comments

@cpina
Copy link
Collaborator

cpina commented Oct 27, 2020

The function onSaveToServer is currently saving the datapackage to the server and it's also showing the Toaster notification (where it informs the user that the datapackage has been saved correctly).

The functionality to show the Toaster notification should probably not be in the onSaveToServer but in higher, UI layer.

This might be handy to refactor if #3 is done: a function onSaveToServer without the notification might be needed in order to "Exit" datacreator-ui or to show the Toaster (depending if it was invoked via "Save to Server" button or "Exit package creator" and then "Save" if implemented in #3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant