-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable black and isort for this repo #5551
Comments
@nabla-c0d3 Perhaps you'd be interested in collaborating with us on this, after the type annotation stuff is merged (will probably still take us a couple of weeks to get through; thanks for all your work on it so far)? |
We're aiming to work on this late in the 10/15-10/29 sprint, or early in the following one. |
(@rmol is still focused on churning through the PR backlog to make this a bit easier, so bumped back to backlog for now.) |
(Doesn't need to be coupled to the next release, removing from milestone for now.) |
Optimistically adding this to the 2.4.0 milestone, would like to land upcoming large changes first if possible though. |
As part of this it would be nice if we could remove the useless |
We've been trialing
black
andisort
for auto-formatting Python code in other SecureDrop repos, and are generally happy with the combination. An example configuration can be found here:https://github.com/freedomofpress/securedrop-client/blob/main/pyproject.toml
https://github.com/freedomofpress/securedrop-client/blob/main/Makefile
We'll want to use the same setup for SecureDrop Core, with the same settings. As with previous migrations (e.g., freedomofpress/securedrop-client#1115), we'll use
.git-blame-ignore-revs
to ensure that original attribution of modified lines is preserved ingit blame
output.The text was updated successfully, but these errors were encountered: