Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChainNode] avoid cyclic handling #52

Open
vatson opened this issue Mar 17, 2012 · 1 comment
Open

[ChainNode] avoid cyclic handling #52

vatson opened this issue Mar 17, 2012 · 1 comment

Comments

@vatson
Copy link
Contributor

vatson commented Mar 17, 2012

There are a couple of cases with cyclic handling.

Problem Node adds itself as the next node.
Solution The issue can be solved by adding a check in AbstractChainNode::nextNode() method.

Problem Imagine a scheme: n1 -> n2 -> n1. In other words, these nodes link to each other.
Solution I dunno. I will be glad to hear your opinion.

@makasim
Copy link
Contributor

makasim commented Mar 19, 2012

I dont think we should take care about it. A developer should test his chain in dev and he will catch the nesting error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants