Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README seems innaccurate - doesTxNeedFrontrunningProtection doesn't check gas > 42,000 #138

Open
samlaf opened this issue Apr 7, 2024 · 0 comments

Comments

@samlaf
Copy link

samlaf commented Apr 7, 2024

The README, in this section, says

  • Does the transaction use more than 42,000 gas? If it doesn't then the Flashbots Relay will reject it, and we're not aware of use cases that use such low gas that need frontrunning protection. Thus, we send low gas transactions to the mempool.

However, doesTxNeedFrontrunningProtection only logs the gas usage but doesn't check that the gasLimit is > 42,000. I also ctrl-f'ed the repo for 42000, 42,000, 42_000` and couldn't find anything.

Is the readme bullet point still accurate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant