refactor: Fix lint issues across the codebase #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
Aug 24, 2023
| ); | ||
|
|
||
| composition = await loadLottie(asset); |
There was a problem hiding this comment.
variable is set twice, trips https://dcm.dev/docs/rules/common/avoid-unnecessary-reassignment
luanpotter
commented
Aug 24, 2023
| @@ -7,12 +7,12 @@ class EmberPlayer extends SpriteAnimationComponent with TapCallbacks { | |||
| EmberPlayer({ | |||
| required super.position, | |||
| required super.size, | |||
| void Function(EmberPlayer)? onTap, | |||
There was a problem hiding this comment.
name Function type parameters, trips https://dcm.dev/docs/rules/common/prefer-explicit-parameter-names
luanpotter
commented
Aug 24, 2023
|
|
||
| linter: | ||
| rules: | ||
| avoid_web_libraries_in_flutter: false |
There was a problem hiding this comment.
better to put it here since it applies project-wise than in a single file
luanpotter
commented
Aug 24, 2023
| @@ -44,37 +44,37 @@ void main() { | |||
| final routes = <String, Game Function()>{ | |||
| 'anchor_by_effect': AnchorByEffectGame.new, | |||
There was a problem hiding this comment.
map keys alphabetical (was almost there)
luanpotter
commented
Aug 24, 2023
| @@ -23,11 +23,11 @@ class RemoveEffectGame extends FlameGame with TapDetector { | |||
|
|
|||
| @override | |||
| void onTap() { | |||
| if (!children.contains(ember)) { | |||
| if (children.contains(ember)) { | |||
There was a problem hiding this comment.
luanpotter
commented
Aug 24, 2023
| @@ -1,6 +1,7 @@ | |||
| import 'package:doc_flame_examples/flower.dart'; | |||
| import 'package:flame/effects.dart'; | |||
| import 'package:flame/game.dart'; | |||
| import 'package:flame/geometry.dart'; | |||
There was a problem hiding this comment.
just using existing declaration of tau
luanpotter
commented
Aug 24, 2023
| import 'package:flame/rendering.dart'; | ||
|
|
||
| const tau = 2 * pi; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a couple lint issues across the codebase, identified by #2667
Nothing controversial, I expect; getting these out of the way so we can focus on discussing bigger things.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?