-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fire_atlas): Encoded option to load json instead of .fa #2649
feat(fire_atlas): Encoded option to load json instead of .fa #2649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great idea! The changes in place right now also look good, I think we should just address this github warning about path not being a dependency of the project, and we should maybe also add a method that saves the atlas as json?
@erickzanardo understood, thank you for your review! |
@erickzanardo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one consideration
@Arenukvern do you want to finish this up with that last comment? If not we'll take it over and fix it. :) |
sorry for late answer, got sick and completely lost free time |
No worries, hope you're feeling better now! |
Description
Hello.
I would like to suggest to add option to load atlas without compression as simple json file.
I found it useful to use for example in itch.io, where gzip encoder causes an error during decoding.
Please notice is just a draft, if it is a case that this change can be useful - I will add all relevant documentation and tests if needed.
Thank you for your time!
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues