Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Option to prevent propagating collision events from ShapeHitbox to _hitboxParent #2594

Merged
merged 8 commits into from
Jul 2, 2023
Merged

feat: Option to prevent propagating collision events from ShapeHitbox to _hitboxParent #2594

merged 8 commits into from
Jul 2, 2023

Conversation

ASGAlex
Copy link
Contributor

@ASGAlex ASGAlex commented Jun 29, 2023

Description

See #2590

Added triggersParentCollision variable to ShapeHitbox class to prevent propogating onCollision* events to parent component

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2590

@ASGAlex
Copy link
Contributor Author

ASGAlex commented Jun 29, 2023

Hmmm, any ideas, what is wrong with tests?....

@spydon spydon changed the title feat: Option to prevent propogating collision events from ShapeHitbox to _hitboxParent feat: Option to prevent propagating collision events from ShapeHitbox to _hitboxParent Jun 29, 2023
@spydon
Copy link
Member

spydon commented Jun 29, 2023

Hmmm, any ideas, what is wrong with tests?....

There has been something strange going on in the GitHub actions lately so that it stops mid-run, re-ran it now and all is green.

spydon
spydon reviewed Jul 2, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some grammar comments, the code itself looks good

doc/flame/collision_detection.md Outdated Show resolved Hide resolved
doc/flame/collision_detection.md Outdated Show resolved Hide resolved
doc/flame/collision_detection.md Outdated Show resolved Hide resolved
packages/flame/lib/src/collisions/hitboxes/shape_hitbox.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/collisions/hitboxes/shape_hitbox.dart Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) July 2, 2023 12:59
@spydon spydon merged commit a58d743 into flame-engine:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to prevent propogating collision events from ShapeHitbox to _hitboxParent
2 participants
@ASGAlex @spydon