feat: Add reusable vector to the Vector2 extension #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Mar 24, 2023
| double ds, | ||
| ) { | ||
| double ds, { | ||
| Vector2? efficientDiff, |
There was a problem hiding this comment.
Maybe we could just have a private static vector in here instead so that the user doesn't have to pass in this vector?
There was a problem hiding this comment.
That's a great idea!
What do you think about sharing it inside the extension by naming it generally?
It might be useful when there is some point to save performance same as moveToTarget.
Hwan-seok
changed the title
spydon
approved these changes
Mar 26, 2023
Co-authored-by: Lukas Klingsbo <[email protected]>
spydon
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a reusable static member which is Vector for reducing object(Vector2) creation overheads if available.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #2427