Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added a page for Joints documentation + ConstantVolumeJoint doc and example #2362

Merged
merged 13 commits into from
Feb 26, 2023

Conversation

eukleshnin
Copy link
Contributor

Description

Added a page for Forge2D joints documentation.
Added a ConstantVolumeJoint documentation and example.

Will add other joint types in the next PRs.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

PR 1/X for #2005

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this is very needed!

doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_forge2d/joints.md Outdated Show resolved Hide resolved
packages/flame_forge2d/example/lib/main.dart Outdated Show resolved Hide resolved
@eukleshnin eukleshnin requested a review from spydon February 25, 2023 23:08
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks for your contribution!

@spydon
Copy link
Member

spydon commented Feb 26, 2023

@eukleshnin seems like I don't have permission to update the branch to latest main, can you press the "Update branch" button?

@eukleshnin
Copy link
Contributor Author

@eukleshnin seems like I don't have permission to update the branch to latest main, can you press the "Update branch" button?

Done!

@spydon spydon merged commit 957ad24 into flame-engine:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants