Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow people to opt-out on repaint boundary #2341

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

renancaraujo
Copy link
Member

@renancaraujo renancaraujo commented Feb 14, 2023

Description

Closes: #2340

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@renancaraujo renancaraujo force-pushed the renan/add-repaint-boundaries-option branch from 6287c41 to 563b22d Compare February 14, 2023 11:12
@spydon spydon changed the title feat: allow people to opt-out on repaint boundary feat: Allow people to opt-out on repaint boundary Feb 14, 2023
@renancaraujo renancaraujo marked this pull request as ready for review February 14, 2023 13:11
Comment on lines +74 to +76
/// Whether the game should assume the behavior of a [RepaintBoundary].
///
/// Defaults to `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the docs mentioned in the commit? 😄
We should probably add a short paragraph about it in the real docs too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find a proper place to add it on the MD files. Also, we don't doc most of the features of the game widget anywhere besides the dart docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed in #2344

@renancaraujo renancaraujo merged commit b6aeec2 into main Feb 14, 2023
@renancaraujo renancaraujo deleted the renan/add-repaint-boundaries-option branch February 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow disabling repaint boundary in the game widget
4 participants