Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refresh vertices on size change of RectangleComponent #2167

Merged
merged 5 commits into from
Nov 22, 2022
Merged

fix: Refresh vertices on size change of RectangleComponent #2167

merged 5 commits into from
Nov 22, 2022

Conversation

ufrshubham
Copy link
Member

@ufrshubham ufrshubham commented Nov 13, 2022 •
edited
Loading

Description

This PR modifies RectangleComponent to register a listener on size so that the vertices can be refreshed.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [NA] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [NA] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2166
Partially this also fixes #1545

spydon
spydon approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, some small tests would be good!

packages/flame/lib/src/geometry/rectangle_component.dart Show resolved Hide resolved
@lukepighetti
Copy link
Contributor

Might also resolve #2178

@ufrshubham ufrshubham marked this pull request as ready for review November 22, 2022 18:17
@spydon spydon requested a review from a team November 22, 2022 20:56
@spydon spydon merged commit 4020d68 into flame-engine:main Nov 22, 2022
@ufrshubham ufrshubham deleted the fix/reactangle-component-refresh-vertices branch November 23, 2022 02:38
@ufrshubham ufrshubham restored the fix/reactangle-component-refresh-vertices branch November 23, 2022 03:17
@ufrshubham ufrshubham deleted the fix/reactangle-component-refresh-vertices branch November 23, 2022 03:17
@spydon spydon mentioned this pull request Nov 23, 2022
Closed
@ufrshubham ufrshubham mentioned this pull request Nov 24, 2022
Closed
@ufrshubham ufrshubham mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RectangleComponent does not re-render paint after construction SizeEffect on PolygonComponent
5 participants
@ufrshubham @lukepighetti @spydon @erickzanardo @wolfenrain