Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for flame_forge2d #2031

Closed
spydon opened this issue Oct 6, 2022 · 5 comments · Fixed by #2068
Closed

Unit tests for flame_forge2d #2031

spydon opened this issue Oct 6, 2022 · 5 comments · Fixed by #2068

Comments

@spydon
Copy link
Member

spydon commented Oct 6, 2022

What could be improved

Currently the bridge library flame_forge2d barely has any tests, it would be good to improve the test coverage here.

  • The BodyComponent should be tested
  • It should test that you can add children to the BodyComponent
  • That those children move and rotate properly with their BodyComponent parent
  • Tests for Forge2DGame
  • Other things that you can come up with

Why should this be improved

So that we don't accidentally break anything when doing changes.

More information

https://github.com/flame-engine/flame/tree/main/packages/flame_forge2d

Good to know

Make sure that you comment on the issue that you will be working on this before starting to program.

To set up the Flame environment you need to follow the instructions in our contributing.md doc, if you have any problems setting up your environment (or other issues of course) feel free to ask for help in the Flame channel on our Discord server.

Read through this to see how we organize the tests in flame:
https://docs.flame-engine.org/1.4.0/development/testing_guide.html

@depimomo
Copy link

depimomo commented Oct 6, 2022

Hello @spydon , I'm sorry after reading the code I'm not sure if I can do this. My background is from javascript and I have a handful experience testing with jest. Currently I'm learning dart and flutter and do some widget test for mobile application. But after I read the code, I don't think I'm capable enough to take this issue. I'm so sorry 🙏

@spydon
Copy link
Member Author

spydon commented Oct 6, 2022

Hello @spydon , I'm sorry after reading the code I'm not sure if I can do this. My background is from javascript and I have a handful experience testing with jest. Currently I'm learning dart and flutter and do some widget test for mobile application. But after I read the code, I don't think I'm capable enough to take this issue. I'm so sorry 🙏

No problem, maybe we'll have some simpler issues popping up in the coming days, keep your eyes open on the Hacktoberfest tag in the issues section.

@dipakp2726
Copy link
Contributor

hello,
i would like to work on it

@ShwetaChauhan18
Copy link
Contributor

@dipakp2726: Let me know if you are not working on this.

@spydon: If @dipakp2726 is not going to complete then I will take this.

@spydon
Copy link
Member Author

spydon commented Oct 7, 2022

hello, i would like to work on it

@dipakp2726 finish your current one first and then we can create some a new one for you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants