Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression for TextComponent #1801

Closed
Hwan-seok opened this issue Jul 16, 2022 · 2 comments · Fixed by #1802
Closed

Performance regression for TextComponent #1801

Hwan-seok opened this issue Jul 16, 2022 · 2 comments · Fixed by #1802
Assignees
Labels
bug fix available A PR fixing this bug is available and waiting for a review

Comments

@Hwan-seok
Copy link
Contributor

Current bug behaviour

After #1720(c44272b), the performance issue came out.
It drops the frame rate from 60 to 20s.

As you can see in the video below, I am using two TextComponent for each player.
After I removed these in the same commit, the performance issue was gone.

FYR, I didn't use the new feature of that PR.

Expected behaviour

Remove some performance issue

Flutter doctor output

[✓] Flutter (Channel stable, 3.0.5, on macOS 12.1 21C52 darwin-arm, locale ko-KR)
    • Flutter version 3.0.5
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (3 days ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK 
    • Platform android-32, build-tools 32.0.0
    • Java binary
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.3)
    • IntelliJ 
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.3)
    • IntelliJ
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.69.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • SM F711N (mobile) • R3CRC0329PF • android-arm64  • Android 12 (API 31)
    • macOS (desktop)   • macos       • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

More environment information

Create a list of more environment information, like:

  • Flame version: c44272b
  • Platform affected: android
    I can confirm that it occurs on Android. I fix this after testing the IOS.
  • Platform version affected: android 12 (confirmed)

More information

Video

Normal

normal.mp4

Has frame drop

frame_drop.mp4
@st-pasha
Copy link
Contributor

@Hwan-seok Please, check if #1802 resolves the problem.

@Hwan-seok
Copy link
Contributor Author

@st-pasha It is resolved!

@st-pasha st-pasha added the fix available A PR fixing this bug is available and waiting for a review label Jul 17, 2022
@st-pasha st-pasha self-assigned this Jul 17, 2022
@st-pasha st-pasha changed the title Performance issue occurs after #1720 Performance regression for TextComponent Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix available A PR fixing this bug is available and waiting for a review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants