Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow changing parent from null parent #1662

Merged
merged 8 commits into from
May 27, 2022
Merged

feat: Allow changing parent from null parent #1662

merged 8 commits into from
May 27, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented May 27, 2022

Description

changeParent should be allowed even when the current parent is null.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

@spydon spydon enabled auto-merge (squash) May 27, 2022 23:26
@spydon spydon merged commit 53268b5 into main May 27, 2022
@spydon spydon deleted the spydon.change-parent-from-null branch May 27, 2022 23:32
st-pasha pushed a commit to st-pasha/flame that referenced this pull request May 29, 2022
@spydon @st-pasha
feat: Allow changing parent from null parent (flame-engine#1662)
2750553 
changeParent should be allowed even when the current parent is null.
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jun 3, 2022
@spydon @st-pasha
feat: Allow changing parent from null parent (flame-engine#1662)
43719e0 
changeParent should be allowed even when the current parent is null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@st-pasha st-pasha st-pasha approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spydon @st-pasha @wolfenrain