Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to save dataset as table, when spark config has remote warehouse info #3645

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

nadejdaSuraeva
Copy link
Contributor

What this PR does / why we need it:

This PR adds a possibility to use saved_dataset as a table for different spark session. The existing solution saves the dataset’s name in registry, but the data exists only within the scope of the spark session.

Which issue(s) this PR fixes:

Fixes #3644

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nadejdaSuraeva
To complete the pull request process, please assign adchia after the PR has been reviewed.
You can assign the PR to them by writing /assign @adchia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nadejdaSuraeva nadejdaSuraeva changed the title feat: add possibility to save dataset as table, when spark config has remote warehouse info feat: Add possibility to save dataset as table, when spark config has remote warehouse info Jun 6, 2023
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@felixwang9817 felixwang9817 merged commit 22c109b into feast-dev:master Aug 14, 2023
felixwang9817 pushed a commit that referenced this pull request Aug 14, 2023
# [0.33.0](v0.32.0...v0.33.0) (2023-08-14)

### Bug Fixes

* Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([#3696](#3696)) ([c75a01f](c75a01f))
* Redshift push ignores schema ([#3671](#3671)) ([76270f6](76270f6))

### Features

* Add possibility to save dataset as table, when spark config has remote warehouse info ([#3645](#3645)) ([22c109b](22c109b))
zseta pushed a commit to zseta/feast that referenced this pull request Feb 7, 2024
… remote warehouse info (feast-dev#3645)

feat: add possibility to save dataset as table, when spark config has remote warehouse info

Signed-off-by: nsuraeva <[email protected]>
Co-authored-by: nsuraeva <[email protected]>
Signed-off-by: Attila Toth <[email protected]>
zseta pushed a commit to zseta/feast that referenced this pull request Feb 7, 2024
# [0.33.0](feast-dev/feast@v0.32.0...v0.33.0) (2023-08-14)

### Bug Fixes

* Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([feast-dev#3696](feast-dev#3696)) ([c75a01f](feast-dev@c75a01f))
* Redshift push ignores schema ([feast-dev#3671](feast-dev#3671)) ([76270f6](feast-dev@76270f6))

### Features

* Add possibility to save dataset as table, when spark config has remote warehouse info ([feast-dev#3645](feast-dev#3645)) ([22c109b](feast-dev@22c109b))

Signed-off-by: Attila Toth <[email protected]>
EXPEbdodla pushed a commit to ExpediaGroup/feast that referenced this pull request Jun 10, 2024
… remote warehouse info (feast-dev#3645)

feat: add possibility to save dataset as table, when spark config has remote warehouse info

Signed-off-by: nsuraeva <[email protected]>
Co-authored-by: nsuraeva <[email protected]>
EXPEbdodla pushed a commit to ExpediaGroup/feast that referenced this pull request Jun 10, 2024
# [0.33.0](feast-dev/feast@v0.32.0...v0.33.0) (2023-08-14)

### Bug Fixes

* Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([feast-dev#3696](feast-dev#3696)) ([c75a01f](feast-dev@c75a01f))
* Redshift push ignores schema ([feast-dev#3671](feast-dev#3671)) ([76270f6](feast-dev@76270f6))

### Features

* Add possibility to save dataset as table, when spark config has remote warehouse info ([feast-dev#3645](feast-dev#3645)) ([22c109b](feast-dev@22c109b))
EXPEbdodla pushed a commit to ExpediaGroup/feast that referenced this pull request Jun 11, 2024
… remote warehouse info (feast-dev#3645)

feat: add possibility to save dataset as table, when spark config has remote warehouse info

Signed-off-by: nsuraeva <[email protected]>
Co-authored-by: nsuraeva <[email protected]>
EXPEbdodla pushed a commit to ExpediaGroup/feast that referenced this pull request Jun 11, 2024
# [0.33.0](feast-dev/feast@v0.32.0...v0.33.0) (2023-08-14)

### Bug Fixes

* Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([feast-dev#3696](feast-dev#3696)) ([c75a01f](feast-dev@c75a01f))
* Redshift push ignores schema ([feast-dev#3671](feast-dev#3671)) ([76270f6](feast-dev@76270f6))

### Features

* Add possibility to save dataset as table, when spark config has remote warehouse info ([feast-dev#3645](feast-dev#3645)) ([22c109b](feast-dev@22c109b))
EXPEbdodla added a commit to ExpediaGroup/feast that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants