Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockWebServer HTTP/2 full support #4193

Closed
manusa opened this issue Jun 8, 2022 · 1 comment · Fixed by #6474
Closed

MockWebServer HTTP/2 full support #4193

manusa opened this issue Jun 8, 2022 · 1 comment · Fixed by #6474
Assignees
@manusa
Labels
component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly component/openshift-server-mock Deals with the openshift-server-mock status/never-stale
Milestone
7.0.0

Comments

@manusa
Copy link
Member

manusa commented Jun 8, 2022

Description

Currently MockWebServer has partial support for HTTP/2 but provides incomplete handshakes. This seems to work for OkHttp, but not for other client implementations.

Provide an MockWebServer alternative with better support for HTTP/2

  • Implement a proper handshake response
    • onStream(Http2Stream stream)
    • readRequest(Http2Stream stream)
  • Remove hardcoded HTTP/1.1 protocol in the RecordedRequest

MockWebServer is final, however, maybe intercepting PRI method requests can help us deal with the problem.
@manusa manusa mentioned this issue Jun 8, 2022
Merged
11 tasks
@stale
Copy link

stale bot commented Sep 6, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Sep 6, 2022
@manusa manusa added status/never-stale component/openshift-server-mock Deals with the openshift-server-mock component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly and removed status/stale labels Sep 7, 2022
@manusa manusa mentioned this issue Dec 20, 2023
Closed
11 tasks
@manusa manusa mentioned this issue Jan 19, 2024
Closed
@manusa manusa added this to the 7.0.0 milestone Mar 7, 2024
@manusa manusa mentioned this issue Oct 21, 2024
Open
@manusa manusa moved this to In Progress in Eclipse JKube Oct 21, 2024
@manusa manusa self-assigned this Oct 21, 2024
@manusa manusa mentioned this issue Oct 21, 2024
Merged
11 tasks
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manusa manusa

Labels
component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly component/openshift-server-mock Deals with the openshift-server-mock status/never-stale
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

feat(mockwebserver): io.fabric8:mockwebserver has full support for HTTP/2 manusa/kubernetes-client
1 participant
@manusa