-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please upgrade source-map to 0.7.2 to get speed improvements #206
Comments
This is awesome, we need to figure out what breaking changes (if any) occurred in 0.7.0, then we are good to go! PRs welcome! |
Hmmmm, this might be a big problem for us... 🤔 |
Is this possible? |
Jest is also unable to upgrade due to the lack of a sync API, FWIW |
I published https://www.npmjs.com/package/@snek/source-map-support which works nicely in node and may work in browsers that allow you to load reasonable sized wasms synchronously. It wraps the 0.8.0-beta.0 release of source-map. |
@andreicristianpetcu |
These are based on the latest You might have luck giving them a try. It's all open-source, so of course the changes can be ported over. |
This will also fix an annoying issue in VS Code. source-map@<0.7.1 has an invalid |
Babel has migrated to https://npmjs.com/package/@jridgewell/trace-mapping, should this module as well? Code change seems fairly trivial (no idea about browser support, but probably?) |
Has anyone done benchmarks of the various options? I haven't, so I really
don't know if they're different: if wasm is faster/slower/whatever.
EDIT: I see them in the README now. Will check them out.
|
Jest and C8 (via |
I can migrate @cspotcode/source-map-support as well. Would be nice to consolidate the ecosystem a bit more. |
The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:
https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072
http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html
https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/
firefox-devtools/debugger#5598
Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.
The text was updated successfully, but these errors were encountered: