fix: metrics-host-allowlist for Teku
#765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
changed the title
metrics-host-allowlist for Tekumetrics-host-allowlist for Teku
pk910
approved these changes
Sep 16, 2024
barnabasbusa
pushed a commit
that referenced
this pull request
Sep 23, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.0](4.2.0...4.3.0) (2024-09-23) ### Features * add prefunded accounts ([#752](#752)) ([1be7efa](1be7efa)) * dora - show more infos about all peers on client pages ([#760](#760)) ([c77d95f](c77d95f)) ### Bug Fixes * `metrics-host-allowlist` for Teku ([#765](#765)) ([ad75fcc](ad75fcc)) * built in validator lifecycle test for assertoor ([#763](#763)) ([6f868cc](6f868cc)) * explicitly set client contexts ([#755](#755)) ([94dc531](94dc531)) * no default resource limits ([#768](#768)) ([4c4831b](4c4831b)) * prysm gRPC removal - use http server instead for keymanager ([#761](#761)) ([ba91174](ba91174)) * remove epoch checker for goomy ([#754](#754)) ([f124bbf](f124bbf)) * remove exp RPC API namespace flag from nimbus-eth1 configuration ([#767](#767)) ([8fec454](8fec454)) * reth-builder volume claim ([#771](#771)) ([4570328](4570328)) * update dora config for latest release & remove custom images ([#748](#748)) ([a433c50](a433c50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
'*'is passed to Teku, which is not correct, so I seeNot Authorizedwhen trying to access Teku metrics, Prometheus says that Teku is down because of 403, and Grafana metrics are empty.Only
*should be passed, which is the purpose of the fix.I don't know how to test it, so not 100% on the fix.