Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the match type in extra-file-input case #1054

Open
kuzdogan opened this issue Jun 7, 2023 · 0 comments
Open

Revisit the match type in extra-file-input case #1054

kuzdogan opened this issue Jun 7, 2023 · 0 comments
Labels
🪲 bug Something isn't working

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Jun 7, 2023

From the discussion in ethereum/solidity#14250 that is a similar bug to #618, I notice we might be verifying the contracts "perfectly" in a wrong way.

This is because when we compile with extra files the metadata file would have been changed, and the hashes wouldn't match. However, in the implementation (ie. useAllSources) we are creating the CheckedContract with the old metadata (with the original sources) but with the sources + extra files. The generated Solidity JSON has files that are not present in the metadata.

That means the compilation is not reproducible.

View in Huly HI-474

@kuzdogan kuzdogan added the 🪲 bug Something isn't working label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@kuzdogan and others