Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No transaction-handling #225

Closed
chland opened this issue Apr 9, 2018 · 2 comments
Closed

No transaction-handling #225

chland opened this issue Apr 9, 2018 · 2 comments

Comments

@chland
Copy link
Contributor

chland commented Apr 9, 2018

Right now, the library isn't using transaction-handling. IMHO it would be a good idea to add it to all functions where multiple updates/deletes are executed to prevent any problems if the db-server dies halfway through deleting stuff. For example in delete_user(), delete_group() or delete_perm(), multiple delete-queries are executed.

I started to add some basic transaction-handling to the code and can create a PR from my changes later today when i'm done.

@REJack
Copy link
Collaborator

REJack commented Apr 10, 2018

That's a great idea and your changes looks good and works.

@REJack
Copy link
Collaborator

REJack commented Nov 11, 2018

Issue closed

@REJack REJack closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants