Add to dock/Remove from dock does not always appear

[teamcons]

What Happened?

Sometimes on a stray click, the item to add to dock does not appear
Tony, our dear Discord mod, does not have it at all

I suppose because dbus does not answer quickly enough, or fails to, get an answer from dock

Doesnt the dock expose on dconf what pinned elements it has ?
It maybe better to have an answer that may be outdated by a second than no entry at all

Steps to Reproduce

I am not sure how to reproduce. It happens randomly to have on a right-click the entry not show up

Expected Behavior

Add/remove from dock. Always. Forever.

OS Version

8.x (Circe)

Session Type

Secure Session (Wayland)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

[danirabbit]

Dconf is not API. There's no guarantee that dock items will always be stored there or that the format will always be the same. So we shouldn't touch dconf keys that don't belong to us. That can lead to crashes